Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Nov 2016 14:39:03 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r308730 - head/sys/dev/usb/net
Message-ID:  <201611161439.uAGEd3VM083355@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Wed Nov 16 14:39:03 2016
New Revision: 308730
URL: https://svnweb.freebsd.org/changeset/base/308730

Log:
  Make sure MAC address is reprogrammed when if_init() callback is
  invoked. Else promiscious mode must be used to pass traffic. While at
  it fix a debug print macro.
  
  MFC after:	1 week

Modified:
  head/sys/dev/usb/net/if_smsc.c

Modified: head/sys/dev/usb/net/if_smsc.c
==============================================================================
--- head/sys/dev/usb/net/if_smsc.c	Wed Nov 16 13:27:39 2016	(r308729)
+++ head/sys/dev/usb/net/if_smsc.c	Wed Nov 16 14:39:03 2016	(r308730)
@@ -152,7 +152,7 @@ static const struct usb_device_id smsc_d
 			device_printf((sc)->sc_ue.ue_dev, "debug: " fmt, ##args); \
 	} while(0)
 #else
-#define smsc_dbg_printf(sc, fmt, args...)
+#define smsc_dbg_printf(sc, fmt, args...) do { } while (0)
 #endif
 
 #define smsc_warn_printf(sc, fmt, args...) \
@@ -822,7 +822,6 @@ static int smsc_sethwcsum(struct smsc_so
 	return (0);
 }
 
-
 /**
  *	smsc_setmacaddress - Sets the mac address in the device
  *	@sc: driver soft context
@@ -905,6 +904,9 @@ smsc_init(struct usb_ether *ue)
 
 	SMSC_LOCK_ASSERT(sc, MA_OWNED);
 
+	if (smsc_setmacaddress(sc, IF_LLADDR(ifp)))
+		smsc_dbg_printf(sc, "setting MAC address failed\n");
+
 	if ((ifp->if_drv_flags & IFF_DRV_RUNNING) != 0)
 		return;
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201611161439.uAGEd3VM083355>