From owner-cvs-all@FreeBSD.ORG Tue May 1 11:20:23 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0404F16A401; Tue, 1 May 2007 11:20:23 +0000 (UTC) (envelope-from rik@inse.ru) Received: from mail.inse.ru (inse.ru [144.206.128.1]) by mx1.freebsd.org (Postfix) with ESMTP id B5B7F13C455; Tue, 1 May 2007 11:20:22 +0000 (UTC) (envelope-from rik@inse.ru) Received: from [127.0.0.1] (www.inse.ru [144.206.128.1]) by mail.inse.ru (Postfix) with ESMTP id 578EF33C4F; Tue, 1 May 2007 15:20:21 +0400 (MSD) Message-ID: <46372416.3020509@inse.ru> Date: Tue, 01 May 2007 15:27:18 +0400 From: Roman Kurakin User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Peter Jeremy References: <200704301516.l3UFGJbu019162@repoman.freebsd.org> <20070430180043.GK13868@elvis.mu.org> <20070430181824.GA83415@nagual.pp.ru> <20070430225717.GA7008@VARK.MIT.EDU> <20070501000242.GA19510@nagual.pp.ru> <20070501002817.GA887@nagual.pp.ru> <463690FE.9000209@inse.ru> <20070501010709.GA1304@nagual.pp.ru> <20070501013957.GX13868@elvis.mu.org> <20070501064828.GA3836@nagual.pp.ru> <20070501105937.GC823@turion.vk2pj.dyndns.org> In-Reply-To: <20070501105937.GC823@turion.vk2pj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Andrey Chernov , cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.sbin/sysinstall main.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2007 11:20:23 -0000 Peter Jeremy wrote: > On 2007-May-01 10:48:28 +0400, Andrey Chernov wrote: > >> On Mon, Apr 30, 2007 at 06:39:57PM -0700, Alfred Perlstein wrote: >> >>> Using the strategy "commit to -current then suffer the fallout" >>> is pretty bogus. >>> >> The only possible. Nobody can run all ports at once. Kris already promise >> all ports build results with those changes in, lets see. >> > > Note that just building the ports with these changes will not demonstrate > much. This change alters the functionality of putenv() rather than the > API/ABI so testing the change requires exercising the ports. This is > a much more difficult task. > I suggest to install all ports sources and grep them at first. I am sure some of ports could be marked as bug-less and other should be marked for exec-check or probably for more accurate review not just grep. rik > >> Apples and oranges. select is BSD own function unlike putenv which is not >> BSD own and initially adopted without too much care. >> > > Then someone needs to fix the "HISTORY" section of getenv(3). I've > looked thru the TUHS and CSRG files and it didn't exist in V7 or any > of the early BSDs. I'm not sure when it really did appear. getenv(3) > in 4.3reno doesn't claim compliance to any standard for putenv(). > >