From owner-cvs-all  Wed Nov 21 11:38:52 2001
Delivered-To: cvs-all@freebsd.org
Received: from mail12.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by hub.freebsd.org (Postfix) with ESMTP id 33B5037B405
	for <cvs-all@FreeBSD.ORG>; Wed, 21 Nov 2001 11:38:35 -0800 (PST)
Received: (qmail 23447 invoked from network); 21 Nov 2001 19:38:34 -0000
Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender <jhb@FreeBSD.org>)
          by mail12.speakeasy.net (qmail-ldap-1.03) with SMTP
          for <peter.jeremy@alcatel.com.au>; 21 Nov 2001 19:38:34 -0000
Message-ID: <XFMail.011121113833.jhb@FreeBSD.org>
X-Mailer: XFMail 1.4.0 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <20011121075927.A74178@gsmx07.alcatel.com.au>
Date: Wed, 21 Nov 2001 11:38:33 -0800 (PST)
From: John Baldwin <jhb@FreeBSD.org>
To: Peter Jeremy <peter.jeremy@alcatel.com.au>
Subject: Re: cvs commit: src/sys/i386/include atomic.h
Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


On 20-Nov-01 Peter Jeremy wrote:
> On Mon, Nov 12, 2001 at 08:57:33AM -0800, John Baldwin wrote:
>>jhb         2001/11/12 08:57:33 PST
>>
>>  Modified files:
>>    sys/i386/include     atomic.h 
>>  Log:
>>  Use newer constraints for inline assembly for an operand that is both an
>>  input and an output by using the '+' modifier rather than listing the
>>  operand in both the input and output sections.
> 
> This change still leaves the non-memory operand's constraint as "ir"
> in all cases - this isn't correct for the char or short cases.  I have
> some old patches to fix this.

There are char and short registers and immediates in x86 asm.  The shorts will
make the assembler insert an extra byte to change the operand size, but it will
still compile.

> In any case, -stable also needs the change to use "+".

Yes, probably so.

> Peter

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message