From owner-freebsd-net@FreeBSD.ORG  Tue Feb 15 14:02:30 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 05EC7106564A
	for <freebsd-net@freebsd.org>; Tue, 15 Feb 2011 14:02:30 +0000 (UTC)
	(envelope-from ndenev@gmail.com)
Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com
	[209.85.161.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C1DA8FC1F
	for <freebsd-net@freebsd.org>; Tue, 15 Feb 2011 14:02:29 +0000 (UTC)
Received: by fxm16 with SMTP id 16so210159fxm.13
	for <freebsd-net@freebsd.org>; Tue, 15 Feb 2011 06:02:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:from:content-type:content-transfer-encoding
	:date:subject:to:message-id:mime-version:x-mailer;
	bh=GC0G7h/Ugkjvz6W2u/JsW6OyvtF0evZlJ//tBx7JMJQ=;
	b=wFRI5kvec1MpLB7UNVDOMYP5tj21KAKdcEErpe1Jl1/W4DKw8kW/LdcAp9sJHGqLmH
	uVksrMA40jNHKVLWGIjc5shBxN2ctfuFP1KR64pzoNH3kRN2TEBfnE4zvy5QffP3HJAn
	71p+VM6hjGlsBtYrVuSwpi4yu5qh1M2vdkwGc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:content-type:content-transfer-encoding:date:subject:to
	:message-id:mime-version:x-mailer;
	b=SLdWK/Hbsan/WLgZoyTJxzfBGLts+Vd/KVAH1a9Trm7a8W+twE6Jia98ONrBtgr1NP
	KrHZGgaut976mzXE4jemYJHKMZpMnOZRfhl3/hT3cVYvqO8+iVMoBobT5gDwR3cgY7Rg
	thXuSOyRMr6sZjifpDoW1+6GTYLbRRbbwS4JU=
Received: by 10.223.100.15 with SMTP id w15mr6202080fan.121.1297778548390;
	Tue, 15 Feb 2011 06:02:28 -0800 (PST)
Received: from ndenevsa.sf.moneybookers.net (g1.moneybookers.com
	[217.18.249.148])
	by mx.google.com with ESMTPS id a2sm1657541faw.22.2011.02.15.06.02.25
	(version=TLSv1/SSLv3 cipher=OTHER);
	Tue, 15 Feb 2011 06:02:26 -0800 (PST)
From: Nikolay Denev <ndenev@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Date: Tue, 15 Feb 2011 16:02:24 +0200
To: freebsd-net@freebsd.org
Message-Id: <D275511D-0502-48ED-9186-EF4BF42B372E@gmail.com>
Mime-Version: 1.0 (Apple Message framework v1082)
X-Mailer: Apple Mail (2.1082)
Subject: ng_ether and vlan interfaces
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Feb 2011 14:02:30 -0000

Hi,

When trying to use ng_ether with vlan interfaces using the naming sheme =
${parent_if}.${vlan_tag}
it produces the following warning :

    ng_ether_attach: can't name node ix0.512

And the newly created netgraph node stays <unnamed>.

This is due to the following check in =
sys/netgraph/ng_base.c:ng_name_node() :

        /* Check the name is valid */
        for (i =3D 0; i < NG_NODESIZ; i++) {
                if (name[i] =3D=3D '\0' || name[i] =3D=3D '.' || name[i] =
=3D=3D ':')
                        break;
        }

Do we really do not want to allow dot in the name?
If it's not an option to allow the dot, probably it would be better to =
replace it with
underscore.

I can provide a patch if the change is acceptable.

Cheers,
Nikolay=