From owner-freebsd-ports-bugs@freebsd.org Tue Apr 11 15:20:27 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCEB9D39C5B for ; Tue, 11 Apr 2017 15:20:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 945D0B53 for ; Tue, 11 Apr 2017 15:20:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v3BFKRcB094581 for ; Tue, 11 Apr 2017 15:20:27 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218564] x11/lightdm: Use correct replacement for clearenv() Date: Tue, 11 Apr 2017 15:20:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: woodsb02@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 15:20:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218564 Bug ID: 218564 Summary: x11/lightdm: Use correct replacement for clearenv() Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: woodsb02@freebsd.org After x11/lightdm was committed to the ports tree, jbeich pointed out that = the function used to clear the process environment in place of clearenv() does = not look right: https://lists.freebsd.org/pipermail/svn-ports-head/2016-December/135993.html The issue with the BSDs not having clearenv() was first raised on the Light= DM bug reporting system related to NetBSD here: https://bugs.launchpad.net/lightdm/+bug/999714 There was discussion about which of the following should be the replacement: putenv ("environ=3DNULL"); environ =3D NULL; The latter option was ultimately committed to LightDM here: http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/revision/1517 However the FreeBSD port was committed with a patch to change the replaceme= nt code to the former option. According to the NOTES section in the Linux kernel manpage for clearenv(3): On systems where clearenv() is unavailable, the assignment environ =3D NULL; will probably do. http://man7.org/linux/man-pages/man3/clearenv.3.html --=20 You are receiving this mail because: You are the assignee for the bug.=