From owner-cvs-src@FreeBSD.ORG Sun Nov 14 23:33:36 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F1CB016A4CE; Sun, 14 Nov 2004 23:33:35 +0000 (GMT) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 68C7D43D4C; Sun, 14 Nov 2004 23:33:35 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.13.0/8.13.0) with ESMTP id iAENXXjn002265; Sun, 14 Nov 2004 18:33:34 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20041114225844.GS8120@darkness.comp.waw.pl> References: <200411141930.iAEJU2I1007666@repoman.freebsd.org> <20041114225844.GS8120@darkness.comp.waw.pl> Date: Sun, 14 Nov 2004 18:33:33 -0500 To: Pawel Jakub Dawidek , "Christian S.J. Peron" From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps ps.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Nov 2004 23:33:36 -0000 At 11:58 PM +0100 11/14/04, Pawel Jakub Dawidek wrote: >On Sun, Nov 14, 2004, Christian S.J. Peron wrote: >+> csjp 2004-11-14 19:30:02 UTC >+> >+> FreeBSD src repository >+> >+> Modified files: >+> bin/ps ps.c >+> Log: >+> Currently if the user specifies -e and procfs is not mounted on >+> /proc, printing of the process environment will fail silently. >+> >+> -define a function which will check to see if procfs is mounted >+> on /proc >+> -Implement this test if the user specified -e >+> -If procfs is not mounted on /proc and -e was specified, print >+> a warning informing the user that procfs(5) is required. > >Hmm, I think I've a fix somewhere to get environment variables >not from procfs... Ah yes, p4:pjd_ps-e. I believe you also had a PR which has that change in it. I noticed that in July (based on a message tjr sent to -current), and intended to do something about it after 5.3-release was finalized. Which I guess would mean I should look at it sometime soon... Looks like the PR is: http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/54604 -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu