From owner-freebsd-ports  Wed Nov  1  6:34:15 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from sapas.dppl.com (unknown [216.182.10.231])
	by hub.freebsd.org (Postfix) with ESMTP
	id AFA4237B6C2; Wed,  1 Nov 2000 06:33:05 -0800 (PST)
Received: from toast.dppl.com (cc167606-a.union1.nj.home.com [24.3.170.57])
	by sapas.dppl.com (Postfix) with ESMTP
	id ABC6474417; Wed,  1 Nov 2000 09:33:04 -0500 (EST)
Received: from dppl.com (localhost [127.0.0.1])
	by toast.dppl.com (Postfix) with ESMTP
	id 8F3934F8D5; Wed,  1 Nov 2000 09:33:02 -0500 (EST)
Message-ID: <3A00299E.16D3F54D@dppl.com>
Date: Wed, 01 Nov 2000 09:33:02 -0500
From: Yarema <yds@dppl.com>
X-Mailer: Mozilla 4.75 [en] (X11; U; Linux 2.2.12 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: will@FreeBSD.org, freebsd-ports@FreeBSD.org,
	"David W. Chapman Jr." <dwcjr@inethouston.net>,
	Terje Elde <terje@thinksec.com>
Subject: Re: ports/21439: FIX: mail/postfix-current
References: <200011010454.UAA20099@freefall.freebsd.org> <3A0022F0.435686CD@dppl.com>
Content-Type: multipart/mixed;
 boundary="------------B5661796FDA130A7B9FEF000"
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

This is a multi-part message in MIME format.
--------------B5661796FDA130A7B9FEF000
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Yarema wrote:
> 
> will@FreeBSD.org wrote:
> >
> > Synopsis: FIX: mail/postfix-current
> >
> > State-Changed-From-To: open->closed
> > State-Changed-By: will
> > State-Changed-When: Tue Oct 31 20:53:56 PST 2000
> > State-Changed-Why:
> > Committed, thanks!
> >
> > http://www.freebsd.org/cgi/query-pr.cgi?pr=21439
> 
> Thanks Will for finally closing that PR and everyone else for improving
> on it. However my fixed pre-install target didn't make it into the port
> as it stands now and the new post-install target never made it into the
> Makefile.  The latter is very important since the port will be broken
> without it. Attached is a diff fixing this as well as a cosmetic fix to
> a message not being proparly alligned because of escaped double quotes
> (\").

Oops.  Just realized I sent the wrong diff.  The one I ment to send and
described above is attached to this message.

Also another part missing in the current port is the following line in
PLIST:

@unexec rm -rf /var/spool/postfix

In my original PR I rationalized it as such:

     Changed
             @dirrm /var/spool/postfix
     to
             @unexec rm -rf /var/spool/postfix
     in PLIST since in practice a) the original line was trying to
remove
     /usr/local//var/spool/postfix which did not exist and b) @dirrm
wouldn't
     work even if it were pointing at the correct path because Postfix
creates a
     number of subdirectories which are not accounted for in PLIST and
which may
     not be empty even if they were accounted for.

I can also see a number of reasons for omitting this line since there
may be undelivered mail sitting in the spool.  Perhaps a message
indicating the directory should be removed manually would be more
apropos.

-- 
Yarema
--------------B5661796FDA130A7B9FEF000
Content-Type: text/plain; charset=us-ascii;
 name="postfix-current.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="postfix-current.diff"

diff -ruN postfix-current.orig/Makefile postfix-current/Makefile
--- postfix-current.orig/Makefile	Wed Nov  1 02:37:39 2000
+++ postfix-current/Makefile	Wed Nov  1 08:50:03 2000
@@ -99,7 +99,10 @@
 	${ECHO} "all: default" >> Makefile)
 
 pre-install:
-	${SH} ${PKGINSTALL} Postfix PRE-INSTALL
+	@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
+
+post-install:
+	@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
 
 do-install:
 	@${INSTALL} -d -o ${BINOWN} -g ${BINGRP} -m 0755 \
@@ -163,10 +166,10 @@
 	@${MKDIR} -m 755 /var/spool/postfix
 	@${CHOWN} root:wheel /var/spool/postfix
 
-	@${ECHO_MSG} "--------------------------------------------------"
-	@${ECHO_MSG} "- To replace your existing sendmail with postfix -"
-	@${ECHO_MSG} "- type \"make replace\"                          -"
-	@${ECHO_MSG} "--------------------------------------------------"
+	@${ECHO_MSG} '--------------------------------------------------'
+	@${ECHO_MSG} '- To replace your existing sendmail with postfix -'
+	@${ECHO_MSG} '- type "make replace"                            -'
+	@${ECHO_MSG} '--------------------------------------------------'
 
 .include <bsd.port.pre.mk>
 

--------------B5661796FDA130A7B9FEF000--



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message