From owner-freebsd-ports-bugs@freebsd.org Tue Feb 2 15:33:57 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B916A9703D for ; Tue, 2 Feb 2016 15:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7BADE19EF for ; Tue, 2 Feb 2016 15:33:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u12FXuQn052431 for ; Tue, 2 Feb 2016 15:33:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 206840] x11-fm/doublecmd: Update to 0.7R6569, Fix build Date: Tue, 02 Feb 2016 15:33:57 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch, needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 15:33:57 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206840 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #3 from Kubilay Kocak --- (In reply to Be=C3=B1at Gonzalez Etxepare from comment #2) You're welcome Be=C3=B1at Basically DISTVERSION can be used to convert incompatible version strings i= nto PORTVERSION compatible ones. That is to say, setting DISTVERSION *automatically* calculates a PORTVERSION value. See Table 5.2 in https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.ht= ml In this case, DISTVERSION=3D0.7R6569 make -V PORTVERSION results in: PORTVERSION =3D 0.7.r6569 Testing this value: pkg version -t 0.7.r6569 0.7.0 < ^--- good (0.7.r6569 is less than future 0.7.0 (true)) Whereas: pkg version -t 0.7R6569 0.7.0 > ^--- not good (0.7R6569 is greater than future 0.7.0 (false)) So you see why we need to use DISTVERSION, otherwise PORTEPOCH will be need= ed in the future. Since we'll be setting DISTVERSION, you may also need to override DISTFILES= in order to derive the correct distribution file filename. Hope that helps explain things :) --=20 You are receiving this mail because: You are the assignee for the bug.=