From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 12:20:48 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A91543C2 for ; Sat, 21 Mar 2015 12:20:48 +0000 (UTC) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 0A103F03 for ; Sat, 21 Mar 2015 12:20:47 +0000 (UTC) Received: (qmail 95436 invoked by uid 89); 21 Mar 2015 12:20:46 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@185.17.207.96) by mail.grem.de with ESMTPA; 21 Mar 2015 12:20:46 -0000 Date: Sat, 21 Mar 2015 13:20:42 +0100 From: Michael Gmelin To: Warner Losh Subject: Re: Changing smbus ABI Message-ID: <20150321132042.141a6b40@bsd64.grem.de> In-Reply-To: <4BA6E6D9-B66B-499F-BDCA-34BD98E4A7DB@bsdimp.com> References: <20150321122653.3e9a9ece@bsd64.grem.de> <4BA6E6D9-B66B-499F-BDCA-34BD98E4A7DB@bsdimp.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; amd64-portbld-freebsd10.0) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/+FzrNXiaB=dZdwAc/_LK/Q+"; protocol="application/pgp-signature" Cc: freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 12:20:48 -0000 --Sig_/+FzrNXiaB=dZdwAc/_LK/Q+ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 21 Mar 2015 06:01:34 -0600 Warner Losh wrote: >=20 > > On Mar 21, 2015, at 5:26 AM, Michael Gmelin wrote: > >=20 > > I'm planning to change the smbcmd structure in an incompatible way > > (see 'man smb' and > > https://reviews.freebsd.org/D1955?id=3D4055#inline-12187) in HEAD. > >=20 > > I'm not aware of any applications relying on this ABI and adding a > > compatibility wrapper later shouldn't be a big deal either. I would > > prefer to avoid the additional complexity introduced by such > > wrapper if it isn't required anyway. >=20 > We have compete code for FreeBSD 4.x in the driver now. Don=E2=80=99t know > why it was added. IIRC, this interface is used by the X server on some > cards to get data from the smbus that=E2=80=99s behind the video chips, w= hich > would likely make compat interface almost required. >=20 I couldn't smbcmd used anywhere, maybe you could point to the correct ports. I checked the sources of x11-drivers/xf86-video* and x11-servers/* (after running make patch on each port). The only file that uses smb is: xf86-video-trident/work/xf86-video-trident-1.3.6/src/trident_tv.c and a couple of pciids mentioning SMBbus, but nothing relying on FreeBSD's native smbus driver. - Michael --=20 Michael Gmelin --Sig_/+FzrNXiaB=dZdwAc/_LK/Q+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJVDWIdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFODQyNDA4MjEyRDI3NjdBRTI5RUZDQTQ2 ODk3RjhDMTZCRkFGRjlGAAoJEGiX+MFr+v+fufEIAJrOgSSS+P4aX3d34VfSuCTE 2eBWoztF311zsBhr15+vBxZ7Mb9oiGjun6+Xjab2XWE1x+qOo7tHkMbBH1RG2Ea/ N/mbJe5KBE25D+cjw0iNQCq/QiOkZERaOOoTkHWjRyzK7wPmRXKksHFS0veEU+zM 1wX815I3l7QEuURp9ZVkJHMwuRVO4Wp5R+AyUT5T47UjNBlelnqQN6W3X0OyudgC F9WtSTZfWQBfAqD9AyZMSCAJ2+Ta0PXNiL35FEUS7TROsJkVq8ptEWwGOlwwZCd0 dL/9mSAlJkMtoANR5bD8kye9aNqutrkod1RnsgfXrYvbN1ov4V4eY30jjatlXLA= =zAEx -----END PGP SIGNATURE----- --Sig_/+FzrNXiaB=dZdwAc/_LK/Q+--