From owner-svn-src-head@FreeBSD.ORG Tue Aug 13 20:54:52 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 4548820D; Tue, 13 Aug 2013 20:54:52 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from mail0.glenbarber.us (mail0.glenbarber.us [IPv6:2607:fc50:1:2300:1001:1001:1001:face]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 197D824B3; Tue, 13 Aug 2013 20:54:52 +0000 (UTC) Received: from glenbarber.us (nucleus.glenbarber.us [IPv6:2001:470:8:1205:2:2:ff:29]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: gjb) by mail0.glenbarber.us (Postfix) with ESMTPSA id 2BE00D09A; Tue, 13 Aug 2013 20:54:50 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.8.3 mail0.glenbarber.us 2BE00D09A Authentication-Results: mail0.glenbarber.us; dkim=none reason="no signature"; dkim-adsp=none Date: Tue, 13 Aug 2013 16:54:48 -0400 From: Glen Barber To: Hiroki Sato Subject: Re: svn commit: r254224 - head/share/man/man7 Message-ID: <20130813205448.GC2241@glenbarber.us> References: <201308111857.r7BIvRSq080970@svn.freebsd.org> <20130814.042557.877689080765344354.hrs@allbsd.org> <20130813195257.GA2241@glenbarber.us> <20130814.053554.1333869805065914360.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MnLPg7ZWsaic7Fhd" Content-Disposition: inline In-Reply-To: <20130814.053554.1333869805065914360.hrs@allbsd.org> X-Operating-System: FreeBSD 10.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2013 20:54:52 -0000 --MnLPg7ZWsaic7Fhd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 14, 2013 at 05:35:54AM +0900, Hiroki Sato wrote: > gj> Why is get_rev_branch() redundant? >=20 > Because variables in get_rev_branch() are already defined in > src/release/Makefile, too. If one wants to use them in release.sh > for some reason, "make -VBRANCH" is preferable instead of duplicating > the same logic in Makefile to extract them from newvers.sh. This > script should not do the same job which Makefile does. >=20 > IMO, the default value of OSRELEASE is not needed here. It seems > used in RELSTRING, but it does not work (and even if it works, it > just generates the same default value). If we always need to > override the default value, Makefile should be fixed instead. >=20 Got it. I think (based on my local revision history) that this was added before the changes to Makefile to set the RELSTRING, when it was done in generate-release.sh. I'll remove it. Glen --MnLPg7ZWsaic7Fhd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJSCp0YAAoJEFJPDDeguUajpEoH/3jRw6GTgnRXKviG/GkTzMPc bNEHPymTdGVQyvRKCCVJM3Bx7p4R9Ky0nrpEju9RuewtZ+7sjn6jzayJO02QQyp2 zEx5bRpYNbkrA47Qyltp4KsWZg2V8wvBmVoDH17zP3yYpvnYS6K39coCkfjEOF3N evZFs7dvVRBHHDNfDdM+VjtIyPAG/twXhAKGOn+kUjY/PjcppJ3tL9BZtGA6oBlg DJLq9Uk+YFP9ckEHv1gam+amrPTyL8O1SqeMsfbBFbi6VbeL3CPcieF+4i7+cVt2 8m43X+l0f50bZiVwoCCe84H43vv+z7Z9ra27mBfNK8N4biu45wSIurTIfWB5lIM= =6fme -----END PGP SIGNATURE----- --MnLPg7ZWsaic7Fhd--