From owner-svn-src-all@freebsd.org Tue Dec 17 14:18:22 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B62251E95BB for ; Tue, 17 Dec 2019 14:18:22 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47cgGk0pbHz4NpR for ; Tue, 17 Dec 2019 14:18:21 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id k6so6012907qki.5 for ; Tue, 17 Dec 2019 06:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EGUQAW/aH6+oZSS3xUykghxjtpvvOqGY/AAjwTKX7J8=; b=DcqlUBiX5GrH3tVlgomH2iLXo8DFDSwY8iWiYN4GZOF/j1F/tS4aye1HH2+35YBBKc PVRdq8OBA8bGHrFlQsglVII5Oj1wQMOfY1yrxLBeY02g4vdvbGwaBH8PxJ6op4lixLuU vOyj4Cq95K9ZLKeVIcMJelRsrDZcBJdUnKCtzQ/PNdFan8+9ZsXMoSxjY00037BRJ6lE 2HEFjM0MmN5e1hjDgNd62WQ+sgIHteop7el4rRfAaIOuWmXCdBz5lCar03a/xyGowwUY 09OWT1FdOpK+ffEWQvo2Qu3R1kkO0huMmPzWBFzGLHBxfdjRdzAghe9ehPsAtLRKF5Q8 7tKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EGUQAW/aH6+oZSS3xUykghxjtpvvOqGY/AAjwTKX7J8=; b=rvpq2pVql84ycSJoX5TOAgjz90f9zbrbYlj/rEzU1VHKCbhDok3vaHZ6Jhaf3D4blw 3ouLoUsysWjJF8FGmRuVkgWl/ic97UZsJK2NGExsJVrhuWEK/NStUVb4r9snQwJob5BE Jbk4w8IbI3fAQYH7CjzrCy8Tb6YSKvULv7weKyTxHsdc/xLMtUCMM4k7WDLQRB6tWKNv 3PricXzSsSprXBrqGqw4ZoAtek3jwhc0oLS+sUxxWSftnwhHPtzNcGsLLXq8qN2XtbbJ tWhbaSYxs+fCcwMl77dx58TQRy8ZxywRBptdiz03wkSI5BLGCK5Pd2jKgqZhzzQ1neF6 qG8Q== X-Gm-Message-State: APjAAAVuMBQ0u88uA9pJEU9YkkDy9e79gdOMSX8oCa11c1bZMnV1yLtq 9kOeJXJyfr38kjGOr+sOJ73DI0NVuQXVEbHGyJrc1A== X-Google-Smtp-Source: APXvYqywFkQuJXOm1bUGTt8sfyA9TsTB261Q5eTMPe3t07Jhp99GUvytls3vZnjYpyoXPg/cTpcazqvnREAEfLddi0c= X-Received: by 2002:a37:4f8e:: with SMTP id d136mr5079626qkb.495.1576592300746; Tue, 17 Dec 2019 06:18:20 -0800 (PST) MIME-Version: 1.0 References: <201912170939.xBH9dFhD096828@gndrsh.dnsmgr.net> In-Reply-To: <201912170939.xBH9dFhD096828@gndrsh.dnsmgr.net> From: Warner Losh Date: Tue, 17 Dec 2019 07:18:09 -0700 Message-ID: Subject: Re: svn commit: r355737 - head/share/man/man9 To: "Rodney W. Grimes" Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47cgGk0pbHz4NpR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=DcqlUBiX; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::729) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.66 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.66)[ip: (-9.18), ipnet: 2607:f8b0::/32(-2.19), asn: 15169(-1.90), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Dec 2019 14:18:22 -0000 On Tue, Dec 17, 2019 at 2:39 AM Rodney W. Grimes wrote: > > On Sun, Dec 15, 2019, 11:51 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > Author: imp > > > > Date: Fri Dec 13 22:32:05 2019 > > > > New Revision: 355737 > > > > URL: https://svnweb.freebsd.org/changeset/base/355737 > > > > > > > > Log: > > > > Better copyright advice > > > > > > > > Document the common practices around copyrights with "all rights > > > reserved" in > > > > them as new copyright notices get added. > > > > > > > > It's an open question qhether to point people at the fact that > since > > > the Berne > > > > convention was ratified, All rights reserved is largely obsolete. > > > > https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence > has the > > > > details. The committer's guide will be revised shortly, and it's > > > likely that's a > > > > better place for this discussion. If not, I'll add a blurb here. > > > > > > > > Reviewed by: jhb@, brooks@ > > > > Differential Review: https://reviews.freebsd.org/D22800 > > > > > > I object to the a review that specifically invites people to it, > > > is authored and committed in anything short of 24 hours and more > > > reasonable to actually ALLOW people time to repond of 72 hours. > > > > > > > The project has no fixed policies around reviews and giving time. Several > > people did look at it and approve it before I committed it. > > Then I'll be blunt, if your going to manually add me to a review > do not commit it until you have given me 72 hours to respond, if > you can not have that respect for my time to response DO NOT MANUALLY > INVITE ME TO YOUR REVIEW. > Sure, I'll respect your wishes, but I don't have to worry about that with anybody else. They just give the feedback when they get a chance to do so... Warner > > Having said that, this isn't like you've lost your ability to say > something > > forever now that this is in the tree. If you have suggestions to > > improvement, I'm all ears. > > > > I like your notion around (c) being noise, but I'll address that in the > > review. > > > > Warner > > > > > > Regards, > > > Rod > > > > > > > > > Better copyright advice > > > AcceptedPublic > > > Authored by imp on Fri, Dec 13, 12:33. > > > > > > > Modified: > > > > head/share/man/man9/style.9 > > > > > > > > Modified: head/share/man/man9/style.9 > > > > > > > > ============================================================================== > > > > --- head/share/man/man9/style.9 Fri Dec 13 22:04:13 2019 > > > (r355736) > > > > +++ head/share/man/man9/style.9 Fri Dec 13 22:32:05 2019 > > > (r355737) > > > > @@ -1,6 +1,5 @@ > > > > .\"- > > > > -.\" Copyright (c) 1995-2005 The FreeBSD Project > > > > -.\" All rights reserved. > > > > +.\" Copyright (c) 1995-2019 The FreeBSD Project > > > > .\" > > > > .\" Redistribution and use in source and binary forms, with or > without > > > > .\" modification, are permitted provided that the following > conditions > > > > @@ -26,7 +25,7 @@ > > > > .\" From: @(#)style 1.14 (Berkeley) 4/28/95 > > > > .\" $FreeBSD$ > > > > .\" > > > > -.Dd June 3, 2019 > > > > +.Dd December 13, 2019 > > > > .Dt STYLE 9 > > > > .Os > > > > .Sh NAME > > > > @@ -84,8 +83,32 @@ comments. > > > > Comments starting in columns other than the first are never > > > > considered license statements. > > > > Use the appropriate SPDX-License-Identifier line before the > copyright. > > > > +If the copyright assertion contains the phrase > > > > +.Dq Li "All Rights Reserved" > > > > +that should be on the same line as the word > > > > +.Dq Li "Copyright" . > > > > +You should not insert a new copyright line between an old > > > > +copyright line and this phrase. > > > > +Instead, you should insert a new copyright phrase after > > > > +a pre-existing > > > > +.Dq Li "All Rights Reserved" > > > > +line. > > > > +When making changes, it is acceptable to fold an > > > > +.Dq Li "All Rights Reserved" > > > > +line with each of the > > > > +.Dq Li "Copyright" > > > > +lines. > > > > +For files that have the > > > > +.Dq Li "All Rights Reserved" > > > > +line on the same line(s) as the word > > > > +.Dq Li "Copyright" , > > > > +new copyright assertions should be added last. > > > > +New > > > > +.Dq Li "Copyright" > > > > +lines should only be added when making substantial changes to the > file, > > > > +not for trivial changes. > > > > .Pp > > > > -After any copyright header, there is a blank line, and the > > > > +After any copyright and license comment, there is a blank line, and > the > > > > .Li $\&FreeBSD$ > > > > for non C/C++ language source files. > > > > Version control system ID tags should only exist once in a file > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org > On Tue, Dec 17, 2019 at 2:39 AM Rodney W. Grimes wrote: > > On Sun, Dec 15, 2019, 11:51 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > Author: imp > > > > Date: Fri Dec 13 22:32:05 2019 > > > > New Revision: 355737 > > > > URL: https://svnweb.freebsd.org/changeset/base/355737 > > > > > > > > Log: > > > > Better copyright advice > > > > > > > > Document the common practices around copyrights with "all rights > > > reserved" in > > > > them as new copyright notices get added. > > > > > > > > It's an open question qhether to point people at the fact that > since > > > the Berne > > > > convention was ratified, All rights reserved is largely obsolete. > > > > https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence > has the > > > > details. The committer's guide will be revised shortly, and it's > > > likely that's a > > > > better place for this discussion. If not, I'll add a blurb here. > > > > > > > > Reviewed by: jhb@, brooks@ > > > > Differential Review: https://reviews.freebsd.org/D22800 > > > > > > I object to the a review that specifically invites people to it, > > > is authored and committed in anything short of 24 hours and more > > > reasonable to actually ALLOW people time to repond of 72 hours. > > > > > > > The project has no fixed policies around reviews and giving time. Several > > people did look at it and approve it before I committed it. > > Then I'll be blunt, if your going to manually add me to a review > do not commit it until you have given me 72 hours to respond, if > you can not have that respect for my time to response DO NOT MANUALLY > INVITE ME TO YOUR REVIEW. > > > > Having said that, this isn't like you've lost your ability to say > something > > forever now that this is in the tree. If you have suggestions to > > improvement, I'm all ears. > > > > I like your notion around (c) being noise, but I'll address that in the > > review. > > > > Warner > > > > > > Regards, > > > Rod > > > > > > > > > Better copyright advice > > > AcceptedPublic > > > Authored by imp on Fri, Dec 13, 12:33. > > > > > > > Modified: > > > > head/share/man/man9/style.9 > > > > > > > > Modified: head/share/man/man9/style.9 > > > > > > > > ============================================================================== > > > > --- head/share/man/man9/style.9 Fri Dec 13 22:04:13 2019 > > > (r355736) > > > > +++ head/share/man/man9/style.9 Fri Dec 13 22:32:05 2019 > > > (r355737) > > > > @@ -1,6 +1,5 @@ > > > > .\"- > > > > -.\" Copyright (c) 1995-2005 The FreeBSD Project > > > > -.\" All rights reserved. > > > > +.\" Copyright (c) 1995-2019 The FreeBSD Project > > > > .\" > > > > .\" Redistribution and use in source and binary forms, with or > without > > > > .\" modification, are permitted provided that the following > conditions > > > > @@ -26,7 +25,7 @@ > > > > .\" From: @(#)style 1.14 (Berkeley) 4/28/95 > > > > .\" $FreeBSD$ > > > > .\" > > > > -.Dd June 3, 2019 > > > > +.Dd December 13, 2019 > > > > .Dt STYLE 9 > > > > .Os > > > > .Sh NAME > > > > @@ -84,8 +83,32 @@ comments. > > > > Comments starting in columns other than the first are never > > > > considered license statements. > > > > Use the appropriate SPDX-License-Identifier line before the > copyright. > > > > +If the copyright assertion contains the phrase > > > > +.Dq Li "All Rights Reserved" > > > > +that should be on the same line as the word > > > > +.Dq Li "Copyright" . > > > > +You should not insert a new copyright line between an old > > > > +copyright line and this phrase. > > > > +Instead, you should insert a new copyright phrase after > > > > +a pre-existing > > > > +.Dq Li "All Rights Reserved" > > > > +line. > > > > +When making changes, it is acceptable to fold an > > > > +.Dq Li "All Rights Reserved" > > > > +line with each of the > > > > +.Dq Li "Copyright" > > > > +lines. > > > > +For files that have the > > > > +.Dq Li "All Rights Reserved" > > > > +line on the same line(s) as the word > > > > +.Dq Li "Copyright" , > > > > +new copyright assertions should be added last. > > > > +New > > > > +.Dq Li "Copyright" > > > > +lines should only be added when making substantial changes to the > file, > > > > +not for trivial changes. > > > > .Pp > > > > -After any copyright header, there is a blank line, and the > > > > +After any copyright and license comment, there is a blank line, and > the > > > > .Li $\&FreeBSD$ > > > > for non C/C++ language source files. > > > > Version control system ID tags should only exist once in a file > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org >