From owner-svn-src-all@FreeBSD.ORG Wed Sep 9 16:31:50 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 809E6106568B; Wed, 9 Sep 2009 16:31:50 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id E839C8FC21; Wed, 9 Sep 2009 16:31:49 +0000 (UTC) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.3/8.14.3) with ESMTP id n89GVk9F037949; Wed, 9 Sep 2009 20:31:46 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1252513906; bh=S2R/iQ+02gUbhQyx4VYVVjqWSgY3mS1RjnLx+K3vz58=; l=475; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=seYHdT7KkxESk7NvwJugUaeNZibHYwVKGKipEvO2JQf3TDCLvEg4lNOk2WJr5g56G VPKyPNH0fShsu2yhZ2g4Dnt47sAS2/GgMy0dpbrFd3tyyc7BOewvmcY8y/4Ve8Y6Wp rAktagIVu71wHj0xOG3hz7dJbmnxyRkYvQLCUoX0= Received: (from ache@localhost) by nagual.pp.ru (8.14.3/8.14.3/Submit) id n89GVj9m037948; Wed, 9 Sep 2009 20:31:45 +0400 (MSD) (envelope-from ache) Date: Wed, 9 Sep 2009 20:31:44 +0400 From: Andrey Chernov To: Dag-Erling Sm??rgrav Message-ID: <20090909163144.GA37924@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Dag-Erling Sm??rgrav , Roman Divacky , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <200909081555.n88FtDwe052523@svn.freebsd.org> <20090909132616.GA35808@nagual.pp.ru> <86d460kv53.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86d460kv53.fsf@ds4.des.no> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, Roman Divacky , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r196981 - head/usr.bin/unzip X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2009 16:31:50 -0000 On Wed, Sep 09, 2009 at 05:14:32PM +0200, Dag-Erling Sm??rgrav wrote: > Andrey Chernov writes: > > If I understand the purpose of this code right, better use > > isalnum()+ispunct()+ispace() > > combination to count non-ASCII people too. > > uh, isprint() perhaps? In some charsets there are a lots of printable characters which are rarely part of the regular text, i.e. pseudographics. isprint() looks too greedy. -- http://ache.pp.ru/