From owner-svn-ports-all@FreeBSD.ORG Fri Mar 7 09:48:41 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 897B83DC; Fri, 7 Mar 2014 09:48:41 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5DCE57B5; Fri, 7 Mar 2014 09:48:40 +0000 (UTC) Received: from [10.31.9.128] (unknown [213.225.137.129]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id A0547438BC; Fri, 7 Mar 2014 03:48:23 -0600 (CST) Message-ID: <531995DB.5000806@marino.st> Date: Fri, 07 Mar 2014 10:48:11 +0100 From: John Marino User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Alexey Dokuchaev , d@delphij.net Subject: Re: svn commit: r345165 - head/devel/hgsvn References: <201402192351.s1JNplot033193@svn.freebsd.org> <20140307070536.GB48720@FreeBSD.org> <53198F86.3020800@delphij.net> <20140307094336.GB3390@FreeBSD.org> In-Reply-To: <20140307094336.GB3390@FreeBSD.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Xin LI , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: marino@freebsd.org List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2014 09:48:41 -0000 On 3/7/2014 10:43, Alexey Dokuchaev wrote: > On Fri, Mar 07, 2014 at 01:21:10AM -0800, Xin Li wrote: >>> If you want to complain about something, complain about the removal >>> of DIST_SUBDIR, not what was already discussed two weeks ago. >> >> I wouldn't mind adding that back but what's the best practice? Do we >> put all python ports in python unless they already have their own >> directory (e.g. zope)? > > DIST_SUBDIR is most useful in few cases (not mutually-exclusive): 1) to > isolate group (perhaps large group) from other distfiles; 2) when distfiles > related to a port do not look related on their own; 3) when two identically > named distfiles (libfoobar-42.tar.gz) belong to different ports, and are > with different contents (if contents is the same, DIST_SUBDIR should not > be used, or be the same to reduce file duplication in $DISTDIR); 4) maybe > something else. The 4) maybe something else is a big one. 4) When upstream "rerolls" their distribution files. The first time this happens, DIST_SUBDIR should get created with a unique date. Otherwise you could have fetch mismatches when the port distinfo is fixed but the old distfile is still on the system. FreeBSD has been pretty lax about rerolls; pkgsrc is much more strict about this. John