From owner-freebsd-current@FreeBSD.ORG Tue May 6 13:17:05 2014 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AB9F7867 for ; Tue, 6 May 2014 13:17:05 +0000 (UTC) Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A0E1C09 for ; Tue, 6 May 2014 13:17:05 +0000 (UTC) Received: by mail-pd0-f177.google.com with SMTP id p10so3896617pdj.8 for ; Tue, 06 May 2014 06:17:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=TBLOxWFuQMHfaC0d3uGXZmxfbNhafTzS6l6a+k9uve4=; b=fFbqMrOnq2FeiCYr3wTZPHpqJzFOtHWv5cjdJAOLwobu056uUnNWqHXsH6V1v6QMRQ TQN7bpfcH0K5hXu9MOJPVTa22gUAFc1cTovxM4dgo0mmDFoFFu5ueyX9AQYDtl99WPTX xD+3JV4iifGApmtKQapU+Pjv1PmjfP9nzWoeQ/l0MrJdoBxqyiVQBht57N7aeuT/QvuP xrZ+rUq/Q7oEXLTVll9QQ7PVVbnlYXFxCCB46rtI5sLuqmDd02mUoswVBfpxhlBRCnc8 8wA3wfIcLZA92jJf6m642uvL3YiN+A07DaoxlO09OyJVnmZVFOBkdyxC31NwjLWwePYx eo/Q== X-Gm-Message-State: ALoCoQnkQglhSxTFvom05NyFcRVVNNDoocPQT43/f8iK1nmrIy4Mx88aV2MpLnyZBrvj3oyhSbQY X-Received: by 10.66.146.199 with SMTP id te7mr6279785pab.106.1399382224095; Tue, 06 May 2014 06:17:04 -0700 (PDT) Received: from [10.64.26.239] (dc1-prod.netflix.com. [69.53.236.251]) by mx.google.com with ESMTPSA id ph1sm97582900pac.14.2014.05.06.06.16.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 06 May 2014 06:16:58 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_1AA88A77-736E-44CA-9235-BA1DA80D6C5F"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: buildworld fails (missing /usr/share/mk/src.opts.mk) From: Warner Losh In-Reply-To: <5368D7F1.4040009@freebsd.org> Date: Tue, 6 May 2014 07:16:55 -0600 Message-Id: References: <5368B0C5.6040309@freebsd.org> <5368C675.1070700@freebsd.org> <5368D7F1.4040009@freebsd.org> To: Stefan Esser X-Mailer: Apple Mail (2.1874) Cc: "current@freebsd.org" , Trond.Endrestol@fagskolen.gjovik.no X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 May 2014 13:17:05 -0000 --Apple-Mail=_1AA88A77-736E-44CA-9235-BA1DA80D6C5F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 6, 2014, at 6:39 AM, Stefan Esser wrote: > Am 06.05.2014 13:44, schrieb Trond Endrest=F8l: >> On Tue, 6 May 2014 13:24+0200, Stefan Esser wrote: >>> Am 06.05.2014 11:52, schrieb Stefan Esser: >>>> Hi Warner, >>>>=20 >>>> as already reported by Jenkins, HEAD does not build. >>>>=20 >>>> Seems that this is caused by src.opts.mk missing in /usr/share/mk >>>> during the cleandir phase. I guess this is kind of a bootstrap >>>> issue - the definitions are looked up in the installed base, not >>>> in the src tree - but did not verify this assumption. >>>>=20 >>>> A work-around is to manually install src.opts.mk: >>>>=20 >>>> # make -C /usr/src/share/mk install >>>>=20 >>>> (which might deserve an UPDATING entry). Falling back on the file >>>> in the src directory might be a better solution ... >>>>=20 >>>> Regards, STefan >>>=20 >>> Following up to my earlier mail: >>>=20 >>> The diagnosis was wrong - the main Makefiles include src.opts.mk = from >>> the source directory. But two sub-ordinate Makefiles missed to = include >>> the new options file (sys/conf/kmod.mk and = sys/modules/drm2/Makefile). >>>=20 >>> I committed a fix/work-around to stop the flood of tinderbox = messages >>> (r265433). >>=20 >> tinderbox still complains about usr.bin/bmake/Makefile.inc. >=20 > Hmmm, I managed to buildworld -HEAD after this patch, but it is > possible, that I had src.opts.mk installed in /usr/share/mk when > I started the build. >=20 > (I later deleted it, to be sure that the version in the source > directory was found and used when building modules, which the > commit actually fixed.) >=20 > I guess the remaining problem is caused by >=20 > .include "src.opts.mk" >=20 > in line 3 of src/usr.bin/bmake/Makefile.inc >=20 > Changing this line to read ".include " seems to fix > it on my system. >=20 > --- usr.bin/bmake/Makefile.inc~ > +++ usr.bin/bmake/Makefile.inc > @@ -1,6 +1,6 @@ > # $FreeBSD$ >=20 > -.include "src.opts.mk" > +.include >=20 > .if defined(.PARSEDIR) > # make sure this is available to unit-tests/Makefile >=20 > It is possible, that the build will still fail at a latter stage, > though (buildworld is still running). >=20 > I committed the above patch, since it gets buildworld through the > bmake subdirectory at least (r265436). If buildworld fails again, > then I'll commit any further missing fixes in one go. I'll know > in some 20 minutes. What is your source system? This is absolutely the wrong change, and = shouldn=92t be necessary at all. These changes survived a universe run = and a few build worlds on other systems. Warner --Apple-Mail=_1AA88A77-736E-44CA-9235-BA1DA80D6C5F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTaODHAAoJEGwc0Sh9sBEAnUEP/Rwccw9ZauYWlsPfixxT/QRH BV0Zl5AkIV+wLJtrajjU3gOt3Omj243l997AfQkkYhHOMTfEfDIW+2qPCQMYczwV 6xXW32PgtWSblNOvEoxWXV84kBqbWBPZvoa7rslemOrK1oDAJTR+oT+CoBoDhcCH jPbay7IhDT6c6AgbBDN6Dy5Iwjs6n10fHXwObHpIx2JHuK17+/1MRvtRPantpcxL MLtHtDCcJ23wRbFXf8FdBcHE7osdX5Q6iKekebIFEJGMqv5C/c66LnaqKHwp8s1E BsJwdHSNBVr2wVfrUwv8Xxl1SvUzcZiCPLVWx156Ed2YPX9WjP+KpZLsx418oV37 9t3jglDSVgk1bNktzdcY2gB0Jztm9Xu+tlJHjsWlWf5IwT/TfK+vttsuYk4Utwbc HwcWTDOGnzX3jO7AiaDDtUeOz5+QVwGJ7bIY3/hHEsrhAtQWXGLB38Mivm32OR4k 6zvG6YRGE3s73XpeQLYGCfSYEeNbtN1W0a4FJOdDSsiLKW0RtryFLLyh+InBFG4W vdWp0KQAlJ6j25tai0n3CgsQ+CHbFO7I33Rbjjqb5ksirljajJrsDyowK2s97qxS JL41octPBF6Hdy+/8Ritkv4oo6M8IqupLMMMPQ4dTEjYoetBv+VMr+mVx56Je0eR mJ1KvDOFmY0Ig9yv1AGJ =Hfq0 -----END PGP SIGNATURE----- --Apple-Mail=_1AA88A77-736E-44CA-9235-BA1DA80D6C5F--