From owner-freebsd-hackers@FreeBSD.ORG Sun Nov 3 00:22:53 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B3ABB3D3 for ; Sun, 3 Nov 2013 00:22:53 +0000 (UTC) (envelope-from royce.williams@gmail.com) Received: from mail-la0-x234.google.com (mail-la0-x234.google.com [IPv6:2a00:1450:4010:c03::234]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 415482110 for ; Sun, 3 Nov 2013 00:22:53 +0000 (UTC) Received: by mail-la0-f52.google.com with SMTP id ev20so2721332lab.11 for ; Sat, 02 Nov 2013 17:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=Farp5h9LTAsnPIyH8yR/s29i+gX1z85jP4eRikQJ8+o=; b=AcEGwUndE9uM5cFU5Aw/TzGf+5swa2lqb8AFfN15wopGf8gshm0Bf6+7Uq+seXr8xc tuBnsg74uLerrmRLWG09uLYu5EV4EhQQrd47R5EtMWd46K+F+x2NATcg8JRRfYsVPlJa q+lLEsHXrw1cVJ43GPOGwCPV0DG3/LGyQRZFXLQsb1RT5rcuPq4I5M8+aMBeCI8bexGs cJEXHT823RIrS5M8JEMfl8pgxEvEQYQJKl8V+zyX0h8hEqsp+/1sfZKs2gZcFGO/9yZZ bUqu3CtQmUX9y/QBJMBO19D5QnDYZbwuxHpGiY8aeHfUFBrUSYy8eU8LzWdyrRN+boJC rO4Q== X-Received: by 10.152.5.162 with SMTP id t2mr6225463lat.1.1383438171055; Sat, 02 Nov 2013 17:22:51 -0700 (PDT) MIME-Version: 1.0 Sender: royce.williams@gmail.com Received: by 10.112.119.169 with HTTP; Sat, 2 Nov 2013 17:22:30 -0700 (PDT) In-Reply-To: <52759664.50800@freebsd.org> References: <526F8EB3.1040205@freebsd.org> <20131102171840.4505cb02@b1c1l1.com> <52759664.50800@freebsd.org> From: Royce Williams Date: Sat, 2 Nov 2013 16:22:30 -0800 X-Google-Sender-Auth: 4YH4YYo5gXeIGFJYqcJPtZaea4E Message-ID: Subject: Re: Automated submission of kernel panic reports To: FreeBSD Hackers Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Nov 2013 00:22:53 -0000 On Sat, Nov 2, 2013 at 4:18 PM, Colin Percival wrote: > On 11/02/13 17:18, Benjamin Lee wrote: > > On Tue, 29 Oct 2013 03:32:19 -0700, Colin Percival > wrote: > >> Hi all, > >> > >> I've written some code for automatically submitting kernel panic > reports, > >> and I'd like some feedback before I place it into the ports tree. > > > > Just a style question, any reason not to place the file names into > > variables? Something like: > > No reason to avoid it, I just don't see any need. It's definitely more "quickly legible" to the human trying to grok the code. Royce