From owner-cvs-all Fri Dec 27 12:39:46 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0B9E37B401; Fri, 27 Dec 2002 12:39:44 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 42B1343EA9; Fri, 27 Dec 2002 12:39:44 -0800 (PST) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.5/8.12.1) with ESMTP id gBRKddnN029946 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Fri, 27 Dec 2002 12:39:40 -0800 (PST)?g (envelope-from sam@errno.com)œ X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange Message-ID: <077e01c2ade8$14365c40$52557f42@errno.com> From: "Sam Leffler" To: "Julian Elischer" , "Nate Lawson" Cc: "Julian Elischer" , , References: Subject: Re: cvs commit: src/sys/netgraph ng_fec.c Date: Fri, 27 Dec 2002 12:39:39 -0800 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > I guess so, but I am making 5.0 match -current. > I will fix -current but as this works I will leave it alone in 5.0 > as that's what's been tested until now. > > Recall that in my commit that changed this I argued this was not a public interface but rather a pact between two specific pieces of code (the one that you and Archie ok'd). That was why I removed it and several other varaibles from the .h file. The fact that other code directly references the variable is probably a bad idea. I think a better solution would be to add a netgraph-specific interface to manipulate this global variable. FWIW I haven't a clue how I missed this module in my global mods. You might want to check if it's included in make LINT (though I thought I also grep'd all code for references). Sam > On Fri, 27 Dec 2002, Nate Lawson wrote: > > > On Mon, 23 Dec 2002, Julian Elischer wrote: > > > Modified files: > > > sys/netgraph ng_fec.c > > > Log: > > > Make ng_fec.c compile again since Sam's changes. > > > > > > Submitted by: Hiten Pandya (hiten@unixdaemons.com) > > > > > > Revision Changes Path > > > 1.3 +8 -5 src/sys/netgraph/ng_fec.c > > > > > > @@ -188,6 +188,10 @@ > > > static void ng_fec_print_ioctl(struct ifnet *ifp, int cmd, caddr_t data); > > > #endif > > > > > > +/* ng_ether_input_p - see sys/netgraph/ng_ether.c */ > > > +extern void (*ng_ether_input_p)(struct ifnet *ifp, struct mbuf **mp, > > > + struct ether_header *eh); > > > + > > > > Shouldn't that be a prototype in a .h if it's a public interface? > > > > -Nate > > > > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message