Date: Fri, 07 Mar 2014 01:49:50 -0800 From: Xin Li <delphij@delphij.net> To: Alexey Dokuchaev <danfe@FreeBSD.org>, d@delphij.net Cc: Mathieu Arnold <mat@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Xin LI <delphij@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r345165 - head/devel/hgsvn Message-ID: <5319963E.1060605@delphij.net> In-Reply-To: <20140307094336.GB3390@FreeBSD.org> References: <201402192351.s1JNplot033193@svn.freebsd.org> <20140307070536.GB48720@FreeBSD.org> <CE672AB00747E2D97403FA66@atuin.in.mat.cc> <53198F86.3020800@delphij.net> <20140307094336.GB3390@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 3/7/14, 1:43 AM, Alexey Dokuchaev wrote: > On Fri, Mar 07, 2014 at 01:21:10AM -0800, Xin Li wrote: >>> If you want to complain about something, complain about the >>> removal of DIST_SUBDIR, not what was already discussed two >>> weeks ago. >> >> I wouldn't mind adding that back but what's the best practice? >> Do we put all python ports in python unless they already have >> their own directory (e.g. zope)? > > DIST_SUBDIR is most useful in few cases (not mutually-exclusive): > 1) to isolate group (perhaps large group) from other distfiles; 2) > when distfiles related to a port do not look related on their own; > 3) when two identically named distfiles (libfoobar-42.tar.gz) > belong to different ports, and are with different contents (if > contents is the same, DIST_SUBDIR should not be used, or be the > same to reduce file duplication in $DISTDIR); 4) maybe something > else. > > In case of DIST_SUBDIR=python, I'm not sure: on my build box here, > it contains about 10 files (Python itself, Sphinx, setuptools). In > $DISTDIR itself, there are some files that start with py2?-?.*. > Thus, I'm not sure if there is a reason to complain about removal > of DIST_SUBDIR; but perhaps python@ gang would disagree. I haven't heard one, but will follow the recommended practice. I have removed it because it looks like very few Python ports do it, this includes mercurial itself, etc. >> Also speaking for that USE_ZIP change, should I restore it to >> previous state (use EXTRACT_SUFX)? > > Technically, yes (if InfoZip is indeed non needed); however, you > might want to do it later alongside with other changes (as USE_ZIP > issue is minuscule). Will do. -----BEGIN PGP SIGNATURE----- iQIcBAEBCgAGBQJTGZY9AAoJEJW2GBstM+nsBrUQAIru48valSjf6lOgXlDS2PoZ Y/KM7cydQu2HmBSL00kn7yTKLzqqqktTn5O5W2BSjbvAjIufrjQXGFMLgPYzf1xz lcGKJigLdwpDiAH9oictKApEGF8HeD8tAN8yfYp2+cOAXhpyxNJZXwVeGoChKGug A+ZGFqp08+vgY4AAI/MLFsM1sEhOun5tbLgUNrCXiWwqh8/t6k/Dz8Sya45cg89c 0+hn35HJ/t59jU1E/AA+1J41lk6Xq/LMXfNWFvtKmTjj1j6jP0DPjIPfw2PUgHIc swDHTaRoCNBOYG4UVG/EEmKUtHowcupa6dKBzwa2Pxxy6OZcCE/6Pp6vY5ZJcplN 6W/yq7byEV0uxq2o50bojZElX61sT62wfyl3zwVlV6HkjZYwqpYeVRFTuJCavSP5 GyzabC09j8WFo0Gux3L4CdMnKGV+kH1D49uIsgC7dy9vaKqEn08zvY4xznZBpL0h 6sfnzFwsS9wzBhxYUKm2+JfM/j57Uv8StbR8hQRw1zgc8py2Z3GJF+H4PXtYVp1Y BWpF6Ci5Ieb8rvjCGfRoYhQT+wQE2hJoPz/qAkH94Okeu7b3fFkB65nnh2Bcp3wf Nc50Jt5M4QWOXeDnXs9Wy/uV8ZZIEo4X/OuXiexLSrbqbQSXUtMIv/ENwt2Zxvpr tXyBJdYXa3YPxpmtSuO4 =QUnO -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5319963E.1060605>