From owner-svn-src-head@FreeBSD.ORG Tue Mar 10 15:52:24 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BB6771065715; Tue, 10 Mar 2009 15:52:24 +0000 (UTC) (envelope-from ga9@york.ac.uk) Received: from buffy.york.ac.uk (buffy.york.ac.uk [144.32.226.160]) by mx1.freebsd.org (Postfix) with ESMTP id 5469C8FC24; Tue, 10 Mar 2009 15:52:23 +0000 (UTC) (envelope-from ga9@york.ac.uk) Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.14.3/8.14.3) with ESMTP id n2AFXTul080882; Tue, 10 Mar 2009 15:33:29 GMT (envelope-from ga9@york.ac.uk) Received: (from ga9@localhost) by buffy.york.ac.uk (8.14.3/8.14.3/Submit) id n2AFXTNF080881; Tue, 10 Mar 2009 15:33:29 GMT (envelope-from ga9@york.ac.uk) X-Authentication-Warning: buffy.york.ac.uk: ga9 set sender to ga9@york.ac.uk using -f From: Gavin Atkinson To: Guido van Rooij In-Reply-To: <200903101519.n2AFJovP065743@svn.freebsd.org> References: <200903101519.n2AFJovP065743@svn.freebsd.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 10 Mar 2009 15:33:28 +0000 Message-Id: <1236699209.62820.32.camel@buffy.york.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 FreeBSD GNOME Team Port Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189624 - head/etc/rc.d X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2009 15:52:25 -0000 On Tue, 2009-03-10 at 15:19 +0000, Guido van Rooij wrote: > Author: guido > Date: Tue Mar 10 15:19:49 2009 > New Revision: 189624 > URL: http://svn.freebsd.org/changeset/base/189624 > > Log: > When swap resides on a mirror and it is not stopped, the mirror > is degraded upon the next reboot and will have to be rebuild. > Thus call swapoff when rebooting (read: when stopping swap1) Is this due to a bug/feature of gmirror? A long time ago, swapoff used to be run on shutdown, but it was removed by pjd@ in src/etc/rc.d/swap1 version 1.9 with the following commit message: | Stop method for swap1 script was introduced, because gmirror needed | it. Now gmirror use shutdown hooks to mark mirrors as clean on | shutdown, so this is not needed anymore. I'm not saying it's not needed, just intrigued why it is now needed again when it never used to be? FWIW, I seem to remember that one of the reasons it was removed was that turning swap off created the possibility that lots of things would be paged back into RAM, which a) could take a long time, and b) fail if there was insufficient RAM. Gavin -- Gavin Atkinson Systems Administrator & Programmer Computing Service, The University of York, York. YO10 5DD Tel: +44 (0)1904 433738 Fax: +44 (0)1904 433740 I have a proof of Fermat's theorem but this .sig is too nar