Date: Fri, 22 Feb 2002 23:28:58 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@FreeBSD.org> Cc: current@FreeBSD.org, dillon@FreeBSD.org Subject: RE: First (easy) td_ucred patch Message-ID: <Pine.BSF.4.21.0202222327490.77168-100000@InterJet.elischer.org> In-Reply-To: <XFMail.020223000035.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I can't look at it till tomorrow. But I've been watching. I'd be surprised if anything broke with what I've seen. I'll look at it then if you haven;t commited by then. On Sat, 23 Feb 2002, John Baldwin wrote: > > On 23-Feb-02 John Baldwin wrote: > > I'm currently testing the following patch whcih is a subset of the td_ucred > > changes. It involves no API changes, but only contains 2 basic changes: > > > > 1) We still need Giant when doing the crhold() to set td_ucred in > > cred_update_thread(). This is an old bug that is my fault. I knew that > > PROC_LOCK was sufficient yet which was my reason for not using td_ucred. > > However, we could still be derferencing a stale p_ucred and doing very bad > > things, so this needs to be fixed until p_ucred is fully protected by the > > PROC_LOCK. This also means that td_ucred is now safe to use. As such: > > > > 2) All the "easy" p->p_ucred -> td->td_ucred changes that don't involve the > > changes to API's such as suser() and p_canfoo(). The next patch in this > > series will most likely be the suser() API change. > > > > http://www.FreeBSD.org/~jhb/patches/ucred.patch > > To apply this patch, use -p6 like so: > > cd work/my/kernel/tree/sys > patch -p6 < path/to/patch/file/ucred.patch > > -- > > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0202222327490.77168-100000>