From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Feb 6 19:10:08 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E752016A420 for ; Mon, 6 Feb 2006 19:10:08 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 52ED943D64 for ; Mon, 6 Feb 2006 19:10:07 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k16JA7sI021284 for ; Mon, 6 Feb 2006 19:10:07 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k16JA7sI021283; Mon, 6 Feb 2006 19:10:07 GMT (envelope-from gnats) Resent-Date: Mon, 6 Feb 2006 19:10:07 GMT Resent-Message-Id: <200602061910.k16JA7sI021283@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Victor Snezhko Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE65F16A420 for ; Mon, 6 Feb 2006 19:07:52 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6556643D4C for ; Mon, 6 Feb 2006 19:07:52 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k16J7q4i053378 for ; Mon, 6 Feb 2006 19:07:52 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k16J7q5R053377; Mon, 6 Feb 2006 19:07:52 GMT (envelope-from nobody) Message-Id: <200602061907.k16J7q5R053377@www.freebsd.org> Date: Mon, 6 Feb 2006 19:07:52 GMT From: Victor Snezhko To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: ports/92912: [patch] x11-wm/sawfish2 writes 1 byte beyond allocated memory X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Feb 2006 19:10:09 -0000 >Number: 92912 >Category: ports >Synopsis: [patch] x11-wm/sawfish2 writes 1 byte beyond allocated memory >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 06 19:10:04 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Victor Snezhko >Release: 7.0-CURRENT >Organization: IndorSoft Ltd. >Environment: FreeBSD freebsd.indorsoft.ru 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Sat Jan 21 08:03:26 NOVT 2006 root@freebsd.indorsoft.ru:/home/vvs/obj/usr/src/sys/VVS i386 >Description: src/fonts.c contains the following code: buf = malloc (len); memcpy (buf, p + 1, len); buf[len] = 0; after the new malloc code has been committed to -current (with debugging enabled by default), sawfish fails to start due to this error. >How-To-Repeat: Install x11-wm/sawfish2 on a 7.0-CURRENT box cvsupped after Jan 13, 2006. It will not start. >Fix: we need to add this patch: vvs@freebsd$ cat /usr/ports/x11-wm/sawfish2/files/patch-src\:\:fonts.c --- src/fonts.c.orig Tue Feb 7 00:15:27 2006 +++ src/fonts.c Tue Feb 7 00:15:37 2006 @@ -131,7 +131,7 @@ if (end == 0) end = p + strlen (p); len = end - (p + 1); - buf = malloc (len); + buf = malloc (len + 1); memcpy (buf, p + 1, len); buf[len] = 0; return buf; >Release-Note: >Audit-Trail: >Unformatted: