Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 16 Oct 2007 22:38:57 GMT
From:      Dominic Fandrey <lon_kamikaze@gmx.de>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/117258: [patch][graphics/libvisual] fix for RELENG_7
Message-ID:  <200710162238.l9GMcv0d041038@www.freebsd.org>
Resent-Message-ID: <200710162240.l9GMe2B9026311@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         117258
>Category:       ports
>Synopsis:       [patch][graphics/libvisual] fix for RELENG_7
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 16 22:40:02 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator:     Dominic Fandrey
>Release:        RELENG_7
>Organization:
private
>Environment:
FreeBSD mobileKamikaze.norad 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #0: Fri Oct 12 16:36:39 CEST 2007     root@homeKamikaze.norad:/usr/obj/TPR40-7/i386/usr/src/sys/TPR40-7  i386
>Description:
Libvisual does not build on RELENG_7, because libvisual requires MMX and the port ignores CFLAGS (and thus CPUTYPE). This patch fixes it and adds -mmmx to the CFLAGS, to make sure that MMX support is activated, even for conservative CPUTYPEs.
>How-To-Repeat:

>Fix:
--- graphics/libvisual/Makefile.orig	2007-10-17 00:29:15.000000000 +0200
+++ graphics/libvisual/Makefile	2007-10-17 00:31:42.000000000 +0200
@@ -21,20 +21,14 @@
 USE_XLIBS=	yes
 USE_GNOME=	gnomehack pkgconfig
 USE_AUTOTOOLS=	libtool:15
-CONFIGURE_ENV=	CFLAGS="-I${LOCALBASE}/include -I${X11BASE}/include ${PTHREAD_CFLAGS}" \
+CONFIGURE_ENV=	CFLAGS="${CFLAGS} -mmmx -I${LOCALBASE}/include -I${X11BASE}/include ${PTHREAD_CFLAGS}" \
 		LIBS="-L${LOCALBASE}/lib -L${X11BASE}/lib ${PTHREAD_LIBS}"
 CONFIGURE_TARGET=	--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
 USE_LDCONFIG=	yes
 
-.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >= 700042 && ${ARCH} == i386
-BROKEN=		Does not compile with GCC 4.2 on i386
-.endif
-
 post-patch:
 	@${REINPLACE_CMD} -e 's|-Wno-unused-variable||g' \
 		-e 's|-O3|${CFLAGS}|g' \
 		${WRKSRC}/libvisual/Makefile.in
 
-.include <bsd.port.post.mk>
+.include <bsd.port.mk>

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710162238.l9GMcv0d041038>