Date: Fri, 4 Nov 2011 00:45:52 -0700 From: Stanislav Sedov <stas@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/graphics/lcms2 Makefile Message-ID: <20111104004552.e5eafd8e.stas@FreeBSD.org> In-Reply-To: <20111104073501.GA83593@FreeBSD.org> References: <201111040341.pA43fLVC046402@repoman.freebsd.org> <20111104002027.b2e8b1bf.stas@FreeBSD.org> <20111104073501.GA83593@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 4 Nov 2011 07:35:01 +0000
Alexey Dokuchaev <danfe@FreeBSD.org> mentioned:
> On Fri, Nov 04, 2011 at 12:20:27AM -0700, Stanislav Sedov wrote:
> > On Fri, 4 Nov 2011 03:41:21 +0000 (UTC)
> > Alexey Dokuchaev <danfe@FreeBSD.org> mentioned:
> > > - Use more standard MANPREFIX instead of MAN1PREFIX which also does not
> > > seem to be documented anywhere
> >
> > It is actually documented in bsd.port.mk, and I don't see a reason to
>
> Hmm, you're right, it is mentioned in bpm, but I find it a bit hard to
> understand:
>
> # MANPREFIX - The directory prefix for ${MAN<sect>} and ${MLINKS}.
> # Default: ${PREFIX}
> # MAN<sect>PREFIX
> # - If manual pages of some sections install in different
> # locations than others, use these.
> # Default: ${MANPREFIX}
>
> In particular, I don't quite get this "some sections install in different
> locations than others" part. Why so complicated? What exactly does it
> suppose to mean?
I have no idea, ask portmgr@.
>
> > change it to MANPREFIX, as MAN1PREFIX has more semantical information
> > in it and correct here, since the manpages installed are meant for the
> > section 1 of the manual.
>
> So how come if it is correct for section N of the manual to use MAN<N>PREFIX
> is it only used in bsd.perl.mk? Frankly speaking I've never seen this
> variable until today, which means vast majority of ports do not use it...
It doesn't make something correct if everybody uses it. I'm not even saing
that using MANPREFIX is wrong. It just seems to me that I don't think
killing off the correct semantical information from the Makefile is the right
thing to do. If hypotetically in the future the FreeBSD project decides
to use a different prefix for MAN1 this port will work automatically.
OTOH I don't really care -- I don't use ports personally anymore. It was
just a suggestion, as I think that MAN1PREFIX is there for a reason.
--
Stanislav Sedov
ST4096-RIPE
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111104004552.e5eafd8e.stas>