From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 5 17:20:05 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E8CC106566C for ; Tue, 5 Aug 2008 17:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 48B828FC27 for ; Tue, 5 Aug 2008 17:20:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m75HK50L085166 for ; Tue, 5 Aug 2008 17:20:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m75HK52Q085165; Tue, 5 Aug 2008 17:20:05 GMT (envelope-from gnats) Date: Tue, 5 Aug 2008 17:20:05 GMT Message-Id: <200808051720.m75HK52Q085165@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Felippe de Meirelles Motta Cc: Subject: Re: ports/126273: [ports] Utilize MASTER_SITES abbreviations. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Felippe de Meirelles Motta List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 17:20:05 -0000 The following reply was made to PR ports/126273; it has been noted by GNATS. From: Felippe de Meirelles Motta To: bug-followup@FreeBSD.org, sunpoet@sunpoet.net Cc: Subject: Re: ports/126273: [ports] Utilize MASTER_SITES abbreviations. Date: Tue, 5 Aug 2008 14:15:00 -0300 --Sig_/YQVsuh6+T=JYq8/PMKz3sPX Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Sunpoet, I take a look on your patch, its ok, but you can optimize it still more. Well ... look some examples: --- /usr/ports/accessibility/py-papi/Makefile 2008-08-04 10:27:22.000000000 +0800 +++ /tmp/ports/accessibility/py-papi/Makefile 2008-08-04 14:36:55.000000000 +0800 CATEGORIES=3D accessibility devel python -MASTER_SITES=3D ${MASTER_SITE_SOURCEFORGE} +MASTER_SITES=3D SF MASTER_SITE_SUBDIR=3D ocemp You can change it to: -MASTER_SITES=3D ${MASTER_SITE_SOURCEFORGE} -MASTER_SITE_SUBDIR=3D ocemp +MASTER_SITES=3D SF/ocemp Other example: --- /usr/ports/archivers/arc/Makefile 2008-04-08 17:01:03.000000000 +0800 +++ /tmp/ports/archivers/arc/Makefile 2008-08-04 14:36:56.000000000 +0800 @@ -9,7 +9,7 @@ PORTVERSION=3D 5.21o PORTREVISION=3D 1 CATEGORIES=3D archivers -MASTER_SITES=3D ${MASTER_SITE_SOURCEFORGE} +MASTER_SITES=3D SF MASTER_SITE_SUBDIR=3D ${PORTNAME} How SF macro already use PORTNAME after MASTER_SITE_SOURCEFORGE, you can change it to: --- /usr/ports/archivers/arc/Makefile 2008-04-08 17:01:03.000000000 +0800 +++ /tmp/ports/archivers/arc/Makefile 2008-08-04 14:36:56.000000000 +0800 @@ -9,7 +9,7 @@ CATEGORIES=3D archivers -MASTER_SITES=3D ${MASTER_SITE_SOURCEFORGE} -MASTER_SITE_SUBDIR=3D ${PORTNAME} +MASTER_SITES=3D SF Good luck and thank you by your contribution to the FreeBSD Project! :) --=20 lippe@FreeBSD.org Felippe de Meirelles Motta --Sig_/YQVsuh6+T=JYq8/PMKz3sPX Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) iEYEARECAAYFAkiYipUACgkQEv+IlQvbYkoKSgCgta8EUz4hQSIWr/BFs4BiE1Tu ndcAoN7WLWg7KFzDARt1m06x9eTtqL1m =kRZN -----END PGP SIGNATURE----- --Sig_/YQVsuh6+T=JYq8/PMKz3sPX--