From owner-freebsd-bugs@freebsd.org  Mon May  1 12:36:20 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2B7DD58FEC
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Mon,  1 May 2017 12:36:20 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9264FE8D
 for <freebsd-bugs@FreeBSD.org>; Mon,  1 May 2017 12:36:20 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v41CaKHg029126
 for <freebsd-bugs@FreeBSD.org>; Mon, 1 May 2017 12:36:20 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 218993] [patch] [ipfw] ipfw(8) may fail to remove rules
Date: Mon, 01 May 2017 12:36:20 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-STABLE
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: eugen@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter attachments.created
Message-ID: <bug-218993-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 May 2017 12:36:20 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218993

            Bug ID: 218993
           Summary: [patch] [ipfw] ipfw(8) may fail to remove rules
           Product: Base System
           Version: 11.0-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: eugen@freebsd.org
          Keywords: patch

Created attachment 182222
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D182222&action=
=3Dedit
clean structures before reusing

Let's try this in a shell:

# n=3D32
# for i in $(jot $n 1); do
> ipfw -q add 1 count ip from any to any
> ipfw -q add 2 count ip from any to any
> done
# ipfw delete 1 2
ipfw: rule 2: setsockopt(IP_FW_XDEL): Invalid argument

Rules numbered 1 got deleted, rules numbered 2 do not.
Note that problem does not manifest if n<32.

A bug is in /sbin/ipfw's ipfw_delete() function that fails to clean "rt"
structure before each iteration. ipfw_zero() function has similar problem.

Attached patch fixes this.

--=20
You are receiving this mail because:
You are the assignee for the bug.=