From owner-svn-ports-all@FreeBSD.ORG Fri Mar 7 09:57:15 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 14E0C8D6; Fri, 7 Mar 2014 09:57:15 +0000 (UTC) Date: Fri, 7 Mar 2014 09:57:15 +0000 From: Alexey Dokuchaev To: marino@freebsd.org Subject: Re: svn commit: r345165 - head/devel/hgsvn Message-ID: <20140307095715.GB16063@FreeBSD.org> References: <201402192351.s1JNplot033193@svn.freebsd.org> <20140307070536.GB48720@FreeBSD.org> <53198F86.3020800@delphij.net> <20140307094336.GB3390@FreeBSD.org> <531995DB.5000806@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <531995DB.5000806@marino.st> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, d@delphij.net, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Mathieu Arnold , Xin LI X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Mar 2014 09:57:15 -0000 On Fri, Mar 07, 2014 at 10:48:11AM +0100, John Marino wrote: > On 3/7/2014 10:43, Alexey Dokuchaev wrote: > > DIST_SUBDIR is most useful in few cases [...] > > 4) When upstream "rerolls" their distribution files. > The first time this happens, DIST_SUBDIR should get created with a > unique date. Otherwise you could have fetch mismatches when the port > distinfo is fixed but the old distfile is still on the system. Yes, I had thought about this case, but deliberately did not mention it as I believe that using DIST_SUBDIR as a remedy for upstream stupidity is abusing it. Instead, upstream should be educated, politely, yet persistently, about how to roll distfiles correctly. That said, while "distfile rerolling" case can indeed be solved with DIST_SUBDIR, IMHO it should not be recommended way. ./danfe