Date: Thu, 16 Sep 2004 10:56:30 -0700 From: Julian Elischer <julian@elischer.org> To: John Baldwin <jhb@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_switch.c Message-ID: <4149D3CE.7020508@elischer.org> In-Reply-To: <200409161036.02801.jhb@FreeBSD.org> References: <200409160537.i8G5bemV019545@repoman.freebsd.org> <xzpmzzqpewe.fsf@dwp.des.no> <200409161036.02801.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote: >On Thursday 16 September 2004 08:38 am, Dag-Erling Smørgrav wrote: > > >>Julian Elischer <julian@FreeBSD.org> writes: >> >> >>> Log: >>> e specific code to revert a partial add ot teh run queue, not >>> remrunqueue() which can't handle a partially added thread. >>> >>> >>begyerpar'n? >> >> Somehow I deleted part of the commit message in the act of committing it.. notice that it starts half way through a word.. >The earlier fix to maybe_preempt() would call 'remrunqueue()' to have a thread >that is being preempted to removed from its ksegroup runqueue, however, >remrunqueue() is for removing the thread from all runqueues, and it is >probably not really safe to call that as the thread is not in a full runqueue >state so to speak. Thus, Julian inlined specific code to just remove the >thread from the ksegroup runqueue. I do wonder if that code shouldn't at >least be consolidated into a function that is called by remrunqueue(), >adjustrunqueue(), and maybe_preempt(). Also, the commit message could use a >bit more detail. :) > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4149D3CE.7020508>