From nobody Wed Mar 11 17:49:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fWJCh73VHz6VVkp for ; Wed, 11 Mar 2026 17:49:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fWJCg4gYNz3fyH for ; Wed, 11 Mar 2026 17:49:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b="C7RiR/s9"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::52c as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-c73a5473bbdso24645a12.2 for ; Wed, 11 Mar 2026 10:49:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773251353; x=1773856153; darn=freebsd.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NIFh8pPpiauCIhJE4+euzNA0YafSNsO2RPnZ5c/Aplc=; b=C7RiR/s9uqa6AqfQC2NkCq3G6qC+zEy73Xh4zdclN8s56etJualJ6J+xF9Re1n5o0/ FQCuy7ZgKT14PzkZ828V/BDI+2rRMxbapOcLuXoDOPxuJommCxNnWLgGi1Q84aQ9G0yV gvF91drf4+H751lpIlaGR0Y6diclNn4Hsp2uTqXhM0Ns5/F8bE8GvBDL2NCKmH7RazAZ rjOft+rR8jPIHXx7B4Y1x8qhVwXbr9yV7G+u6Dk9vFExBFDH0HQP3+PcZT/70Us+hsvH jZ92bEx7xht4dfjzUALb5ZLxOM/PfBeV/QeJsBjRXyINLoZF76Av3I88sex7K3/P1u0R WTAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773251353; x=1773856153; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=NIFh8pPpiauCIhJE4+euzNA0YafSNsO2RPnZ5c/Aplc=; b=EMptSOAvzPwD8dugiI6lrVys70qJUjH65p2/zyXeOPzYmytCjSykbNgI5piXqFHuQe bnQBvIRxf5d+dtovSJHLU+ZR8nQf6BrfcVh+mfttbVZ01cAyxbR5LZwaHs9oWfcJaAmd MqDrr5hDghj4frAKh4wNXHnEVHKzOxTcJeQFGS/6bHDGFycmSDn+X8+zia8uThKlggcm jeXDl+euacopF/9MmeLCJQcDGAS+ygvIjDAuO+kX19G2Qb6tq+QQE8xHnPLlAoFP46wL FfURM7dnH5z1+NrfjmJoo4+osrlMggf+D2mDDc0D38PLN0vF2O/U+hIXqmsRsSrurfau Xt0Q== X-Forwarded-Encrypted: i=1; AJvYcCVH//kGJBd+w+FZBEZm57v/tSh0M/frti1N0QctqHiAVFQ7cy6sZvghds1c3d6+2livXFaMkYasIbDwrC7FZyWQXRBo@freebsd.org X-Gm-Message-State: AOJu0YyXM7ddcmgLKqG9SP4DiOBajA/nfaNfgtdmvvUTj6nFKqJdbyIz XlTouaes+sxSfeMo+iYsg2Y3Avdv6dPsxrtbEBjh8SaKpZ+A6g8TbrKy X-Gm-Gg: ATEYQzxwP5N2nkHW3JUnJNxbVZZ9MvfeCHFsQ7mLeCglhqgdoqrTxOd3sPyoceT5xgx FDrWtBcz96pPituB9JGmxkuJ98rVyIXqjaxir6m0aIzP01TrGlLZ5PTqUAPImhXXOUYu2hrpl+k wZQA1l8hNLtq2EB+sp+Ba0i0iENFxWELwe9F8TiPHNdhCZ2axyDSFA7ANmHnM2kCu9nfu0o94iN H1GCM8ithCMXd7f+LxqQMjoNLV0XHRrtQNSYd4v9Eburx5Jcw4sYbnuJxdU7DAd78cpUjQKg1L6 uxkW07Q+CYGbQzhS7fllkpH6nWtdPZCIqbcPLH/Glzg6w43v+rFV6sVIADqtuCvokFE1tdQX5YB DhmJdtjzkYZj/QcyAw4Ge/yOuIgJnJnkQQ1A1uxK714dAqFupEOHk6I/W4JX/MfhjYNozE915ds WnSgoNvU6WtCOMZaZTguFvqn/7hOQnqycTNQP0fScYtMOXn+ESrx8N X-Received: by 2002:a05:6a20:72a5:b0:394:5d0d:9217 with SMTP id adf61e73a8af0-398c60ce53fmr3563997637.44.1773251353405; Wed, 11 Mar 2026 10:49:13 -0700 (PDT) Received: from smtpclient.apple ([185.153.179.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07365b22sm246861b3a.45.2026.03.11.10.49.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Mar 2026 10:49:12 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: f26cb4757eb7 - main - LinuxKPI: avoid -Werror=unused-value in sort() from BUILD_BUG_ON_ZERO() From: "Enji Cooper (yaneurabeya)" In-Reply-To: <69a735cf.1c359.19b4d8ff@gitrepo.freebsd.org> Date: Wed, 11 Mar 2026 10:49:02 -0700 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <016D1851-1087-4014-8A29-77C3C2D9C2A5@gmail.com> References: <69a735cf.1c359.19b4d8ff@gitrepo.freebsd.org> To: Siva Mahadevan X-Mailer: Apple Mail (2.3826.700.81.1.4) X-Spamd-Result: default: False [-3.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::52c:from] X-Rspamd-Queue-Id: 4fWJCg4gYNz3fyH X-Spamd-Bar: --- > On Mar 3, 2026, at 11:26=E2=80=AFAM, Siva Mahadevan = wrote: >=20 > The branch main has been updated by siva: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df26cb4757eb74ceace39144933ae198e= bf1b4f28 >=20 > commit f26cb4757eb74ceace39144933ae198ebf1b4f28 > Author: Siva Mahadevan > AuthorDate: 2026-03-03 19:09:35 +0000 > Commit: Siva Mahadevan > CommitDate: 2026-03-03 19:19:32 +0000 >=20 > LinuxKPI: avoid -Werror=3Dunused-value in sort() from = BUILD_BUG_ON_ZERO() >=20 > The BUILD_BUG_ON_ZERO() macro returns an (int)0 if it does not fail > at build time. LinuxKPI sort() has it as a guard for an unsupported > argument but ignores the return value. >=20 > This leads to gcc complaining: >=20 > = /usr/src/sys/compat/linuxkpi/common/include/linux/build_bug.h:60:33: = error: statement with no effect [-Werror=3Dunused-value] > 60 | #define BUILD_BUG_ON_ZERO(x) ((int)sizeof(struct { = int:-((x) !=3D 0); })) > | ^ > /usr/src/sys/compat/linuxkpi/common/include/linux/sort.h:37:9: = note: in expansion of macro 'BUILD_BUG_ON_ZERO' > 37 | BUILD_BUG_ON_ZERO(swap); \ > | ^~~~~~~~~~~~~~~~~ > /usr/src/sys/contrib/dev/rtw89/core.c:2575:9: note: in expansion of = macro 'sort' > 2575 | sort(drift, RTW89_BCN_TRACK_STAT_NR, = sizeof(*drift), cmp_u16, NULL); >=20 > Change to BUILD_BUG_ON() for the statement version. Thank you Siva! My mailbox and the gcc tinderbox build thanks you :).. -Enji=