From owner-freebsd-ports  Fri May  5 09:34:15 1995
Return-Path: ports-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id JAA02340
          for ports-outgoing; Fri, 5 May 1995 09:34:15 -0700
Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id JAA02332
          for <freebsd-ports@FreeBSD.org>; Fri, 5 May 1995 09:34:12 -0700
Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id JAA09216; Fri, 5 May 1995 09:34:00 -0700
From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
Message-Id: <199505051634.JAA09216@gndrsh.aac.dev.com>
Subject: Re: make.conf and bsd.ports.mk
To: kargl@troutmask.apl.washington.edu (Steven G Kargl)
Date: Fri, 5 May 1995 09:34:00 -0700 (PDT)
Cc: freebsd-ports@FreeBSD.org
In-Reply-To: <199505051604.JAA27016@troutmask.apl.washington.edu> from "Steven G Kargl" at May 5, 95 09:04:14 am
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 1637      
Sender: ports-owner@FreeBSD.org
Precedence: bulk

> 
> According to Rodney W. Grimes:
> > 
> > > 
> > > Satoshi, Jordan, whomever,
> > > 
> > > Is there an obvious reason (that I am missing) why bsd.port.mk does
> > > not scan make.conf for CFLAGS?  The only place I can find that uses
> > > make.conf is sys.mk, but this isn't used for ports.
> > 
> > If you type ``make'' sys.mk is read, you have to do a ``make -r'' to
> > stop make from reading /usr/share/mk/sys.mk.
> > 
> > The problem you are most likely seeing is that most Makefile's in
> > the ports have there own .c.o rules that overrides the one in sys.mk :-(.
> > 
> 
> I knew the answer was probably simply, but I'm not too familiar with how
> the *.mk files interact.
> 
> I played around with the port of top-3.3, and found that if I changed the
> Makefile in top/work from
> 
> CDEF = -O
> CFLAGS = -DHAVE_GETOPT $(CDEF)
> 
> to
> 
> #CDEF = -O
> CFLAGS += -DHAVE_GETOPT $(CDEF)
> 
> The build does the Right Thing.  Should this type of change be added to
> the GUIDELINES for porting to FreeBSD?  I admit I like the convenience
> of the ports, but I don't want to edit the Makefile(s) in every port to
> include CFLAGS = -O2 -m486 -pipe (e.g., consider the fun of editing the
> Makefiles in XFree86).

It would involve a lot of patching, but would be a nice feature.  Satoshi
is the one who will have to decide what to do here.

> Rod, do you have a separate business related email address?

Nope, it all goes into one big basket :-)  FreeBSD is my life now :-)


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation Company                   Custom computers for FreeBSD