From owner-freebsd-current@freebsd.org Tue Dec 15 07:44:15 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C06CA4ABE39 for ; Tue, 15 Dec 2020 07:44:15 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from ms-10.1blu.de (ms-10.1blu.de [178.254.4.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cw9Hy2cr5z3GWw; Tue, 15 Dec 2020 07:44:13 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from [188.174.54.230] (helo=c720-r368166.unixarea.de) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kp50F-00034B-MW; Tue, 15 Dec 2020 08:44:11 +0100 Received: from c720-r368166.fritz.box (localhost [127.0.0.1]) by c720-r368166.unixarea.de (8.16.1/8.14.9) with ESMTPS id 0BF7iBD0002187 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 15 Dec 2020 08:44:12 +0100 (CET) (envelope-from guru@unixarea.de) Received: (from guru@localhost) by c720-r368166.fritz.box (8.16.1/8.14.9/Submit) id 0BF7iBTX002186; Tue, 15 Dec 2020 08:44:11 +0100 (CET) (envelope-from guru@unixarea.de) X-Authentication-Warning: c720-r368166.fritz.box: guru set sender to guru@unixarea.de using -f Date: Tue, 15 Dec 2020 08:44:11 +0100 From: Matthias Apitz To: freebsd-current@freebsd.org, kaktus@freebsd.org, sbruno@freebsd.org Cc: Michael Gmelin , Hans Petter Selasky Subject: Re: after update to r368166: no sound recording Message-ID: Reply-To: Matthias Apitz Mail-Followup-To: freebsd-current@freebsd.org, kaktus@freebsd.org, sbruno@freebsd.org, Michael Gmelin , Hans Petter Selasky References: <72bd5240-3092-bf7b-51aa-2ad12a576efb@selasky.org> <4d83e630-7bed-16bd-3422-267813d3e842@selasky.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: FreeBSD 13.0-CURRENT r368166 (amd64) X-message-flag: Mails containing HTML will not be read! Please send only plain text. X-Con-Id: 51246 X-Con-U: 0-guru X-Originating-IP: 188.174.54.230 X-Rspamd-Queue-Id: 4Cw9Hy2cr5z3GWw X-Spamd-Bar: / X-Spamd-Result: default: False [-0.53 / 15.00]; HAS_REPLYTO(0.00)[guru@unixarea.de]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[178.254.4.101:from]; HAS_XAW(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; RECEIVED_SPAMHAUS_PBL(0.00)[188.174.54.230:received]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[178.254.4.101:from]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:42730, ipnet:178.254.0.0/19, country:DE]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.67)[0.667]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[unixarea.de]; AUTH_NA(1.00)[]; SPAMHAUS_ZRD(0.00)[178.254.4.101:from:127.0.2.255]; RCVD_IN_DNSWL_LOW(-0.10)[178.254.4.101:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[no SPF record]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Dec 2020 07:44:15 -0000 El día lunes, diciembre 14, 2020 a las 10:16:21a. m. +0100, Matthias Apitz escribió: > I did a step by step down grading with 'svn up -r..... hdaa.c hdaa.h' > (only these two files), starting from r368166 down to the following revisions: > > r368166: no recording from pcm1 > > r358333: no recording from pcm1 > > r350078: no recording from pcm1 > > r337043: recording is fine > > I've cc'ed now the commiters of the r358333 and r350078. kaktus@ and sbruno@ > please check the issue https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251727 > and this mail thread in current@ I have nailed down the problem and locally fixed it with this: # svn diff sys/dev/sound/pci/hda/hdaa.c Index: sys/dev/sound/pci/hda/hdaa.c =================================================================== --- sys/dev/sound/pci/hda/hdaa.c (revisión: 368166) +++ sys/dev/sound/pci/hda/hdaa.c (copia de trabajo) @@ -6598,6 +6598,7 @@ devinfo->newgpo = -1; callout_init(&devinfo->poll_jack, 1); devinfo->poll_ival = hz; + devinfo->init_clear = 1; /* added by guru@unixarea.de */ hdaa_lock(devinfo); res = hda_command(dev, because there seems to be no code to set devinfo->init_clear from loader.conf; there is in hdaa.c: SYSCTL_ADD_INT(device_get_sysctl_ctx(dev), SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), OID_AUTO, "init_clear", CTLFLAG_RW, &devinfo->init_clear, 1,"Clear initial pin widget configuration"); but I don't see any function like hdaa_init_clear_handler() which writes the value to devinfo->init_clear; Am I mistaken? matthias -- Matthias Apitz, ✉ guru@unixarea.de, http://www.unixarea.de/ +49-176-38902045 Public GnuPG key: http://www.unixarea.de/key.pub