From owner-freebsd-current@FreeBSD.ORG Wed Jul 30 12:34:38 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DFC5A37B420 for ; Wed, 30 Jul 2003 12:34:37 -0700 (PDT) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC74343FAF for ; Wed, 30 Jul 2003 12:34:36 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 7996 invoked from network); 30 Jul 2003 19:34:36 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender )encrypted SMTP for ; 30 Jul 2003 19:34:36 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.9/8.12.9) with ESMTP id h6UJYXGI068459; Wed, 30 Jul 2003 15:34:34 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.4 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030724183246.X42809@root.org> Date: Wed, 30 Jul 2003 15:34:54 -0400 (EDT) From: John Baldwin To: Nate Lawson cc: current@freebsd.org cc: scsi@freebsd.org Subject: RE: PATCH: Disable 6 byte commands for USB, firewire, ATAPICAM X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2003 19:34:38 -0000 On 25-Jul-2003 Nate Lawson wrote: > Attached is a patch that disables ever sending 6 byte commands to buses > that do not support them. Numerous USB devices hang when receiving a 6 > byte command. For testing, this patch comments out the scsi_da quirks for > devices that I believe are addressed by this patch and no longer need the > quirk. > > Please test devices such as USB keys, USB cameras, Firewire hard disks, > and ATAPICAM cd drives to be sure they still work with this patch. > Especially if you've needed a quirk before, it is important to see if this > patch does not break your device. I hope to get this into the tree early > so there is plenty of testing before 5.2. You should remove the 6 to 10 translation that is already in umass(4) for UFI and ATAPI devices. I didn't do it for SCSI devices because the SCSI transport was supposed to work ok with 6 byte commands. Not all devices properly report their transport though. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/