From owner-svn-ports-all@FreeBSD.ORG  Fri Mar  7 10:02:09 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 69A9CD1E;
 Fri,  7 Mar 2014 10:02:09 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3DBBA959;
 Fri,  7 Mar 2014 10:02:08 +0000 (UTC)
Received: from [10.31.9.128] (unknown [213.225.137.129])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 153DF438BC;
 Fri,  7 Mar 2014 04:01:56 -0600 (CST)
Message-ID: <53199908.4010008@marino.st>
Date: Fri, 07 Mar 2014 11:01:44 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r345165 - head/devel/hgsvn
References: <201402192351.s1JNplot033193@svn.freebsd.org>
 <20140307070536.GB48720@FreeBSD.org>
 <CE672AB00747E2D97403FA66@atuin.in.mat.cc> <53198F86.3020800@delphij.net>
 <20140307094336.GB3390@FreeBSD.org> <531995DB.5000806@marino.st>
 <20140307095715.GB16063@FreeBSD.org>
In-Reply-To: <20140307095715.GB16063@FreeBSD.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, d@delphij.net, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>,
 Xin LI <delphij@FreeBSD.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Mar 2014 10:02:09 -0000

On 3/7/2014 10:57, Alexey Dokuchaev wrote:
> On Fri, Mar 07, 2014 at 10:48:11AM +0100, John Marino wrote:
>> On 3/7/2014 10:43, Alexey Dokuchaev wrote:
>>> DIST_SUBDIR is most useful in few cases [...]
>>
>> 4) When upstream "rerolls" their distribution files.
>> The first time this happens, DIST_SUBDIR should get created with a
>> unique date.  Otherwise you could have fetch mismatches when the port
>> distinfo is fixed but the old distfile is still on the system.
> 
> Yes, I had thought about this case, but deliberately did not mention it as I
> believe that using DIST_SUBDIR as a remedy for upstream stupidity is abusing
> it.  Instead, upstream should be educated, politely, yet persistently, about
> how to roll distfiles correctly.  That said, while "distfile rerolling" case
> can indeed be solved with DIST_SUBDIR, IMHO it should not be recommended way.

They are not mutually exclusive.
You can and should educate upstream.  In the meantime, the damage is
done and needs to be dealt with properly.  It's to the maintainer's
benefit to educate upstream to avoid PRs and constantly updating the
port, so this is no crutch.  It doesn't stop additional work, it's just
correct.

John