From owner-cvs-all Sat Oct 3 05:52:30 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id FAA06662 for cvs-all-outgoing; Sat, 3 Oct 1998 05:52:30 -0700 (PDT) (envelope-from owner-cvs-all) Received: from nlsystems.com (nlsys.demon.co.uk [158.152.125.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA06644; Sat, 3 Oct 1998 05:52:12 -0700 (PDT) (envelope-from dfr@nlsystems.com) Received: from herring.nlsystems.com (herring.nlsystems.com [10.0.0.2]) by nlsystems.com (8.9.1/8.8.5) with SMTP id NAA14616; Sat, 3 Oct 1998 13:49:16 +0100 (BST) Date: Sat, 3 Oct 1998 13:49:16 +0100 (BST) From: Doug Rabson To: Luigi Rizzo cc: Brian Somers , luigi@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/i386/isa/snd CARDS README ad1848.c dmabuf.c mss.h sb_dsp.c sbcard.h sound.c sound.h In-Reply-To: <199810030939.KAA00766@labinfo.iet.unipi.it> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@freebsd.org X-Loop: FreeBSD.org Precedence: bulk On Sat, 3 Oct 1998, Luigi Rizzo wrote: > > > luigi 1998/10/02 10:26:38 PDT > > > > > > Modified files: > > > sys/i386/isa/snd CARDS README ad1848.c dmabuf.c mss.h > > > sb_dsp.c sbcard.h sound.c sound.h > ... > > This seems to break with ``controller pnp0'' (in my case anyway). > > what exactly breaks ? I had this code compiled and working on a > 980925 SNAP with a PnP sound card (unless i did some mistake when > applying the patchfile... not unlikely when doing interactive work > with 20% loss...) There is a problem with a duplicated case in a switch statement in ad1848.c: Index: ad1848.c =================================================================== RCS file: /home/ncvs/src/sys/i386/isa/snd/ad1848.c,v retrieving revision 1.12 diff -u -r1.12 ad1848.c --- ad1848.c 1998/10/02 17:26:36 1.12 +++ ad1848.c 1998/10/03 11:18:34 @@ -1487,7 +1487,6 @@ case 0x3500630e: /* CS4236 */ case 0x3600630e: /* CS4236 */ - case 0x3500630e: /* CS4236B */ tmp_d.bd_id = MD_CS4236 ; break; -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039