From owner-freebsd-rc@FreeBSD.ORG Mon Jun 6 23:08:54 2005 Return-Path: X-Original-To: freebsd-rc@FreeBSD.org Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 90ACE16A41C; Mon, 6 Jun 2005 23:08:54 +0000 (GMT) (envelope-from jr@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19DD443D4C; Mon, 6 Jun 2005 23:08:53 +0000 (GMT) (envelope-from jr@opal.com) Received: from linwhf.opal.com (112.79.171.66.subscriber.vzavenue.net [66.171.79.112]) by smtp.vzavenue.net (MOS 3.4.8-GR) with ESMTP id CIS08939; Mon, 6 Jun 2005 19:08:51 -0400 (EDT) Received: from ASSP-nospam (localhost [127.0.0.1]) by linwhf.opal.com (8.13.3/8.13.3) with ESMTP id j56N8pHW038137; Mon, 6 Jun 2005 19:08:51 -0400 (EDT) (envelope-from jr@opal.com) Received: from 127.0.0.1 ([127.0.0.1] helo=linwhf.opal.com) by ASSP-nospam ; 6 Jun 05 23:08:51 -0000 Received: (from jr@localhost) by linwhf.opal.com (8.13.3/8.13.3/Submit) id j56N8pOV038136; Mon, 6 Jun 2005 19:08:51 -0400 (EDT) (envelope-from jr) Date: Mon, 6 Jun 2005 19:08:51 -0400 From: "J.R. Oldroyd" To: Doug Barton Message-ID: <20050606230850.GE37208@linwhf.opal.com> References: <20050603143803.GP886@linwhf.opal.com> <42A4CA37.1050201@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42A4CA37.1050201@FreeBSD.org> User-Agent: Mutt/1.4.2.1i X-Junkmail-Status: score=0/50, host=smtp.vzavenue.net Cc: freebsd-rc@FreeBSD.org Subject: Re: Use of rcorder for local rc.d/*.sh scripts X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jun 2005 23:08:54 -0000 On Jun 06, 15:12, Doug Barton wrote: > >If not, could we make the following change to /etc/rc.d/localpkg: > > > >--- localpkg.orig Fri Oct 8 13:52:43 2004 > >+++ localpkg Thu Jun 2 16:53:56 2005 > >@@ -36,7 +36,7 @@ > > done > > script_save_sep="$IFS" > > IFS="${script_name_sep}" > >- for script in ${slist}; do > >+ for script in `rcorder -s nostart ${slist} 2>/dev/null`; do > > This is an interesting approach. I'm in favor of incorporating rcorder for > local scripts (whether ports, or homegrown stuff), but I think I prefer an > approach that brings all the scripts into the fray, so that local scripts > that need to execute before parts of the base can do so. Have you put any > thought into such an approach? > Yes, and I'd prefer that myself. We'd need to eliminate /etc/rc.d/localpkg and merge its functionality into /etc/rc. The change would actually be trivial: --- /etc/rc Thu Jun 2 09:07:12 2005 +++ rc.new Mon Jun 6 19:03:05 2005 @@ -72,7 +72,23 @@ skip="-s nostart" [ `/sbin/sysctl -n security.jail.jailed` -eq 1 ] && skip="$skip -s nojail" -files=`rcorder ${skip} /etc/rc.d/* 2>/dev/null` + +# For each dir in $local_startup, search for init scripts matching *.sh +# +case ${local_startup} in +[Nn][Oo] | '') + ;; +*) + local_rc_files="" + for dir in ${local_startup}; do + if [ -d "${dir}" ]; then + local_rc_files="${local_rc_files} ${dir}/*.sh" + fi + done + ;; +esac + +files=`rcorder ${skip} /etc/rc.d/* ${local_rc_files} 2>/dev/null` for _rc_elem in ${files}; do run_rc_script ${_rc_elem} ${_boot} Also, a similar change for /etc/rc.shutdown. -jr