From nobody Wed Feb 14 18:36:01 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TZn2V1QV8z51l8h; Wed, 14 Feb 2024 18:36:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TZn2V0zdQz4Y5N; Wed, 14 Feb 2024 18:36:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707935762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hZxYfhI8gzslcOYCrYiZ8cyU1+USNH1qBrdcrQGsi0I=; b=dHVF5CDqKDxkk9bVTPw+xQ09NWCOmmbain+51itLRqSlaP+naTSLl1aCbAi0tKD7RFn/HR W+IPgqBWapWAm20H16TA0LL5ldqVJ6RrIttIN/Sk8giKv6pauNII53McfHqcIFyyeHCfts OzbBLqFOB+10aed8vKprft/TbgoXTuksm1wHE13mFipbtn4j+oR1LDiucnY580U/yvX8dy Ih71H2JTC2UlB8BiMQQlYISoOyzSw5Qq2kk1NmPIZC7TJKHDmEm9G8eoOR1EUBIE0ux/oz MLPQ/NJblZ07fljOxXGZ8CyDofLMn9TCDab1dwspibKczQJ3N1sC1xio8DY4tw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1707935762; a=rsa-sha256; cv=none; b=Rm68BO0MWBJMpdEp/sRoJWBHmb2N3cfXfCmGPKa4lV0KyFBOaLzGNkpaoet6R5dKDqub46 Pphy/39/YQJfnvKC7yQL9Zbt4fqXscpXdB3WpEjXxr1fQRQC+qbio64eGT/CERyyaudRRS ZXHSrfuhg5yOs02UfOkBSR251VfcttEid4HNvo/pjjn0jBIJx8dNwq7qa38CZtvBY/Hyen Uhn4TX41GEYNfvvd9nCKEolz6dE3uxJBG2g3fSQ73y2QtkmpWAQvPJWvEq3IGlZ2nRac/G GeIhBo28dj0GwyAY+6IiKhD8eT8mz/rYrZrxIDIPQicSqPSYgzlsuV8VybSpqg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1707935762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hZxYfhI8gzslcOYCrYiZ8cyU1+USNH1qBrdcrQGsi0I=; b=PZ3Z0tj2Rh0ZPL4oj+f4GoatxkE1J5QhLqIacb+O00Cw1Fj5ibSEDG8XaVjhDnLTZQRsVJ V5MWjEAgAyODkS0yq4vS7XgUUV9RVXN3JtU/I04F7onLrfPca0uOZKpW3Lrsa5GPiCP1we Nb56t+JrahUseqWhM16pPjt2UlfJaA7gT/dBHF8SIzb6hdz7i5gqMcZfQJyPLzWDIHHMUE FmzGzXhXZ5cyJlKtSUB6BHF2Y/MGPuhz1m3jJV3AogGmXPpRVMyY0N4jvCLncV1DHmw7Er Spp8bIAeFElMVJ/BC0wGDqPyLvbNax8KRFXha5opku6aL2IZ7lPohSG+mpSTmQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TZn2V0294z1844; Wed, 14 Feb 2024 18:36:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41EIa1oN050878; Wed, 14 Feb 2024 18:36:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41EIa1dl050875; Wed, 14 Feb 2024 18:36:01 GMT (envelope-from git) Date: Wed, 14 Feb 2024 18:36:01 GMT Message-Id: <202402141836.41EIa1dl050875@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: a27c1350e43a - main - loader: Make vidc_biosputchar static List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a27c1350e43a863fbe2bf0927ef762a20babe5d5 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=a27c1350e43a863fbe2bf0927ef762a20babe5d5 commit a27c1350e43a863fbe2bf0927ef762a20babe5d5 Author: Warner Losh AuthorDate: 2024-02-14 18:07:10 +0000 Commit: Warner Losh CommitDate: 2024-02-14 18:22:57 +0000 loader: Make vidc_biosputchar static It's currently unused outside of vidconsole.c. Gerald Hicks' fix to the beep code from de37e4a6d2333/1998 introduced the funciton as static. Maxim Sobolev (sobomax) made it non-static since his spinconsole called it in c4c3b35172d67/2009. When sobomax dropped the direct call after making spinconsole console independent in b35172d67/2017, vidc_biosputchar remained a harmless unreferenced global. Make it static once again. Fixes: c7e10205ae0d Sponsored by: Netflix --- stand/i386/libi386/vidconsole.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stand/i386/libi386/vidconsole.c b/stand/i386/libi386/vidconsole.c index aec41a6373d6..f8a6bf34acad 100644 --- a/stand/i386/libi386/vidconsole.c +++ b/stand/i386/libi386/vidconsole.c @@ -1046,7 +1046,7 @@ vidc_init(int arg) return (0); /* XXX reinit? */ } -void +static void vidc_biosputchar(int c) {