From owner-cvs-all@FreeBSD.ORG Tue Mar 25 10:11:36 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B208E106566B; Tue, 25 Mar 2008 10:11:36 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from nat-application.b1.lan.prg.vol.cz (nat-application.b1.lan.prg.vol.cz [195.122.204.152]) by mx1.freebsd.org (Postfix) with ESMTP id 0BB208FC25; Tue, 25 Mar 2008 10:11:35 +0000 (UTC) (envelope-from pav@FreeBSD.org) Received: from pav.hide.vol.cz (localhost [127.0.0.1]) by nat-application.b1.lan.prg.vol.cz (8.14.2/8.14.2) with ESMTP id m2PABYuK072862; Tue, 25 Mar 2008 11:11:34 +0100 (CET) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by pav.hide.vol.cz (8.14.2/8.14.2/Submit) id m2PABY8k072861; Tue, 25 Mar 2008 11:11:34 +0100 (CET) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: pav.hide.vol.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Alexey Dokuchaev In-Reply-To: <20080325100618.GB16355@FreeBSD.org> References: <200803242042.m2OKgSmG034282@repoman.freebsd.org> <20080325095905.GA16355@FreeBSD.org> <1206439241.71921.9.camel@pav.hide.vol.cz> <20080325100618.GB16355@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-4D0pxEJl8AcY3lkIbOs2" Date: Tue, 25 Mar 2008 11:11:34 +0100 Message-Id: <1206439894.71921.13.camel@pav.hide.vol.cz> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 FreeBSD GNOME Team Port Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Alejandro Pulver , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/alienarena Makefile distinfo pkg-descr pkg-message ports/games/alienarena/files alienarena-ded.in alienarena-sdl.in alienarena.in patch-Makefile patch-client__menu.c patch-game__acesrc__acebot.h patch-game__acesrc__acebot_nodes.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Mar 2008 10:11:36 -0000 --=-4D0pxEJl8AcY3lkIbOs2 Content-Type: text/plain; charset=ISO8859-2 Content-Transfer-Encoding: quoted-printable Alexey Dokuchaev p=ED=B9e v =FAt 25. 03. 2008 v 10:06 +0000: > On Tue, Mar 25, 2008 at 11:00:41AM +0100, Pav Lucistnik wrote: > > Alexey Dokuchaev p??e v ?t 25. 03. 2008 v 09:59 +0000: > > > On Mon, Mar 24, 2008 at 08:42:28PM +0000, Alejandro Pulver wrote: > > > > Log: > > > > Both data and program: > > > > - Update to version 2008. > > > > =20 > > > > Only for games/alienarena: > > > > - Remove local patches (now integrated upstream). > > > > - Check for WITH_* instead of !WITHOUT_* (avoid double negation). > > >=20 > > > I've been under impression that common practice is to check for WITH_= FOO > > > with knobs that are default to off, and !WITHOUT_FOO that default to = on. > >=20 > > No longer needed with OPTIONS. >=20 > Technically I would agree, but it breaks traditional convention and > consistency for little reason. Doing it the old way also aids in reading > the Makefile, in a certain way. We don't need to be bug compatible with our past code. --=20 Pav Lucistnik Video games don't affect kids, I mean if Pac Man affected us as kids, we'd all run around in a darkened room munching pills and listening to repetitive music. -- Kristian Wilson, CEO at Nintendo Gaming Corporation Inc --=-4D0pxEJl8AcY3lkIbOs2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?UTF-8?Q?digit=C3=A1ln=C4=9B?= =?ISO-8859-1?Q?_podepsan=E1?= =?UTF-8?Q?_=C4=8D=C3=A1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEABECAAYFAkfoz9YACgkQntdYP8FOsoJq7wCcDziDV/SZsFFDtaX3Ytm3hOdx jagAnjlmCarPkH20M5Tx4j3RdtkIvccl =xVtV -----END PGP SIGNATURE----- --=-4D0pxEJl8AcY3lkIbOs2--