From owner-cvs-all Thu Sep 20 1:36: 7 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (straylight.ringlet.net [217.75.134.254]) by hub.freebsd.org (Postfix) with SMTP id B3F7737B40E for ; Thu, 20 Sep 2001 01:36:00 -0700 (PDT) Received: (qmail 8988 invoked by uid 1000); 20 Sep 2001 08:33:26 -0000 Date: Thu, 20 Sep 2001 11:33:26 +0300 From: Peter Pentchev To: Kris Kennaway Cc: "David W. Chapman Jr." , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/security/ssh2 pkg-plist Message-ID: <20010920113326.A8974@ringworld.oblivion.bg> Mail-Followup-To: Kris Kennaway , "David W. Chapman Jr." , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200109141351.f8EDpRX81320@freefall.freebsd.org> <20010914195142.A56820@xor.obsecurity.org> <20010916125446.A513@ringworld.oblivion.bg> <20010916142112.B22230@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010916142112.B22230@xor.obsecurity.org>; from kris@obsecurity.org on Sun, Sep 16, 2001 at 02:21:12PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Sep 16, 2001 at 02:21:12PM -0700, Kris Kennaway wrote: > On Sun, Sep 16, 2001 at 12:54:46PM +0300, Peter Pentchev wrote: > > > +# Include extra files if X11 is installed > > +.if defined(WITH_X11) || (exists(${X11BASE}/lib/libX11.a) \ > > + && !defined(WITHOUT_X11)) > > +USE_XLIB= yes > > +PLIST_SUB+= WITH_X="" > > I'm not sure this is correct. If X is installed, you can disable the > port from building with it, but if X is not installed you can't make > it build with X support (i.e. the WITH_X11 check is nonfunctional, I > think). Erm.. if you define WITH_X11, the USE_XLIB=yes will bring in a lib dependency on the X port, no? G'luck, Peter -- If there were no counterfactuals, this sentence would not have been paradoxical. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message