From owner-cvs-all Tue Jan 29 8:37:42 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.musha.org (daemon.musha.org [61.122.44.178]) by hub.freebsd.org (Postfix) with ESMTP id 9673F37B404; Tue, 29 Jan 2002 08:37:32 -0800 (PST) Received: from archon.local.idaemons.org (archon.local.idaemons.org [192.168.1.32]) by mail.musha.org (Postfix) with ESMTP id AE4124D95D; Wed, 30 Jan 2002 01:37:27 +0900 (JST) Date: Wed, 30 Jan 2002 01:37:27 +0900 Message-ID: <86sn8pazaw.wl@archon.local.idaemons.org> From: "Akinori MUSHA" To: Mikhail Teterin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/irc/sirc Makefile ports/irc/zircon Makefile ports/japanese/bjfilter850 Makefile ports/japanese/easypr Makefile ports/japanese/edict Makefile ports/japanese/emacs20-emcws Makefile ports/japanese/epwutil Makefile ... In-Reply-To: <200201291616.g0TGGsQ90665@aldan.algebra.com> References: <200201291108.g0TB8qx51380@freefall.freebsd.org> <200201291616.g0TGGsQ90665@aldan.algebra.com> User-Agent: Wanderlust/2.9.5 (Unchained Melody) SEMI/1.14.3 (Ushinoya) LIMIT/1.14.7 (Fujiidera) APEL/10.3 MULE XEmacs/21.1 (patch 14) (Cuyahoga Valley) (i386--freebsd) Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At Tue, 29 Jan 2002 11:16:51 -0500 (EST), Mikhail Teterin wrote: > On 29 Jan, Akinori MUSHA wrote: > > Log: > > Use ${ECHO_CMD} instead of ${ECHO} where you mean the echo command; > > the ECHO macro is set to "echo" by default, but it is set to "true" > > if make(1) is invoked with the -s option while ECHO_CMD is always > > set to the echo command. > > Actually, in my opinion, using shell comment -- hash -- is even better > instead of ECHO (not ECHO_CMD). I think you mean ECHO_MSG here. :) ECHO_MSG is used to output an informational message to a terminal, while ECHO_CMD is used to output a string to a file or through a pipe. The difference between them is that ECHO_MSG can be disabled by setting it to a null command (true) for automated building, while ECHO_CMD may not be disabled because it is essential to be functional in order to output given strings properly. The problem I fixed is that ECHO was used where it should be ECHO_CMD - as explained in the commit log, ECHO can be set to a null command when make(1) is invoked with the -s option. > foo: > - @${ECHO} bar > + # bar > > Yes, you see the extraneous ``#'' on the output, but it should be much > lighter on the system. Shell ignores the line, but make echos it out. > And it looks neater in the Makefile. That's an idea. They are almost equivalent except the # character, as 'make -s' suppresses the output. :) -- / /__ __ Akinori.org / MUSHA.org / ) ) ) ) / FreeBSD.org / Ruby-lang.org Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp "Somewhere out of a memory.. of lighted streets on quiet nights.." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message