From owner-svn-src-head@freebsd.org Sat Sep 23 08:37:50 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0019E2AD17; Sat, 23 Sep 2017 08:37:50 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 812DE6C410; Sat, 23 Sep 2017 08:37:49 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 450B425D3891; Sat, 23 Sep 2017 08:37:44 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 53701D1F928; Sat, 23 Sep 2017 08:37:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id F1m1wvRgmdGk; Sat, 23 Sep 2017 08:37:39 +0000 (UTC) Received: from [192.168.124.1] (fresh-ayiya.sbone.de [IPv6:fde9:577b:c1a9:f001::2]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 5A4F5D1F894; Sat, 23 Sep 2017 08:37:38 +0000 (UTC) From: "Bjoern A. Zeeb" To: "Stephen Hurd" Cc: "Stephen Hurd" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323942 - head/sys/net Date: Sat, 23 Sep 2017 08:37:30 +0000 Message-ID: <6F5DC92C-2CF6-4A33-9663-BFECB7DB65F2@lists.zabbadoz.net> In-Reply-To: <283397c7-a01e-3776-7ed3-b64d68003d0b@sasktel.net> References: <201709230135.v8N1ZE6S063264@repo.freebsd.org> <283397c7-a01e-3776-7ed3-b64d68003d0b@sasktel.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6091) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Sep 2017 08:37:50 -0000 On 23 Sep 2017, at 6:32, Stephen Hurd wrote: > Bjoern A. Zeeb wrote: >> On 23 Sep 2017, at 1:35, Stephen Hurd wrote: >> >>> Author: shurd >>> Date: Sat Sep 23 01:35:14 2017 >>> New Revision: 323942 >>> URL: https://svnweb.freebsd.org/changeset/base/323942 >>> >>> Log: >>> Chain mbufs before passing to if_input() >>> >>> Build a list of mbufs to pass to if_input() after LRO. Results in >>> 12% small packet forwarding rate improvement. >> forwarding seems a confusing word here.. > > The test was small (64 byte frames) received on one interface, then > sent out on a different one using the net.inet.ip.forwarding sysctl > (controlled via the gateway_enable setting in rc.conf). Then this makes no sense as we don’t do LRO if forwarding is enabled on the machine; https://svnweb.freebsd.org/base/head/sys/netinet/tcp_lro.c?annotate=317390#l645