From owner-freebsd-security@FreeBSD.ORG Tue Jun 20 19:44:44 2006 Return-Path: X-Original-To: freebsd-security@freebsd.org Delivered-To: freebsd-security@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6F86F16A479; Tue, 20 Jun 2006 19:44:44 +0000 (UTC) (envelope-from jasone@FreeBSD.org) Received: from lh.synack.net (lh.synack.net [204.152.188.37]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1440143D48; Tue, 20 Jun 2006 19:44:44 +0000 (GMT) (envelope-from jasone@FreeBSD.org) Received: by lh.synack.net (Postfix, from userid 100) id ED5455E4919; Tue, 20 Jun 2006 12:44:43 -0700 (PDT) Received: from [192.168.168.201] (70-37-200-108.losaca.adelphia.net [70.37.200.108]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lh.synack.net (Postfix) with ESMTP id 852675E4912; Tue, 20 Jun 2006 12:44:42 -0700 (PDT) Message-ID: <44985028.6020901@FreeBSD.org> Date: Tue, 20 Jun 2006 12:44:40 -0700 From: Jason Evans User-Agent: Mozilla Thunderbird 1.0.8-1.4.1 (X11/20060420) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Dan Lukes References: <20060618203903.31161.qmail@web30306.mail.mud.yahoo.com> <44967861.6070509@obluda.cz> <20060620125350.10d0c9ef.nick@nickwithers.com> <44980ECC.5000607@obluda.cz> <20060620170353.GB90842@gothmog.pc> <449833DD.70904@FreeBSD.org> <44984A25.8060001@obluda.cz> In-Reply-To: <44984A25.8060001@obluda.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.0.6 (2005-12-07) on lh.synack.net X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed version=3.0.6 X-Mailman-Approved-At: Wed, 21 Jun 2006 02:01:10 +0000 Cc: freebsd-security@freebsd.org, Giorgos Keramidas Subject: Re: memory pages nulling when releasing X-BeenThere: freebsd-security@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Security issues \[members-only posting\]" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2006 19:44:44 -0000 Dan Lukes wrote: > Jason Evans napsal/wrote, On 06/20/06 19:43: > >>>> BTW, Z nor J doesn't imply 'R' despite of text of manual page. > >> The man page looks accurate to me. What aspect of the descriptions of >> 'J' and 'Z' do you think is incorrect? > > From manual page: > ======================= > J ... > This options also sets the ``R'' option. > ... > Z This option implicitly sets the ``J'' and ``R'' options, > ======================= > > From libc/stdlib/malloc.c (the lines containing malloc_realloc + > some lines around) > ======================= > static int malloc_realloc; > ... > case 'r': malloc_realloc = 0; break; > case 'R': malloc_realloc = 1; break; > case 'j': malloc_junk = 0; break; > ... > if (!malloc_realloc && /* Unless we have to, */ > size <= osize && /* .. or are too small, ... > if (!malloc_realloc && /* Unless we have to, */ > size <= osize && /* ..or are too small, */ > ======================= > > The malloc_realloc seems to be set on one place only - when R/r > present. Then it is used only. I see no dependency to J nor Z > > I send no PR because I have submitted several more important PR's > which are untouched for months. I don't want to overload committers nor > PR database. Ah, this is for RELENG_6. I had assumed you were talking about -current. I agree with you that the man page is inaccurate for RELENG_6. I don't currently use RELENG_6 for development though, so I'd recommend submitting a PR with a patch assigned to the docs folks if you want it fixed. In my experience they are very responsive where man page accuracy is concerned. Jason