From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Aug 21 11:40:00 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id C48026B6 for ; Wed, 21 Aug 2013 11:40:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A4ED523A0 for ; Wed, 21 Aug 2013 11:40:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r7LBe0MA030764 for ; Wed, 21 Aug 2013 11:40:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r7LBe0Qg030763; Wed, 21 Aug 2013 11:40:00 GMT (envelope-from gnats) Resent-Date: Wed, 21 Aug 2013 11:40:00 GMT Resent-Message-Id: <201308211140.r7LBe0Qg030763@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Kalten Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E2F54657 for ; Wed, 21 Aug 2013 11:38:01 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B7032237E for ; Wed, 21 Aug 2013 11:38:01 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r7LBc11X080343 for ; Wed, 21 Aug 2013 11:38:01 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r7LBc18p080338; Wed, 21 Aug 2013 11:38:01 GMT (envelope-from nobody) Message-Id: <201308211138.r7LBc18p080338@oldred.freebsd.org> Date: Wed, 21 Aug 2013 11:38:01 GMT From: Kalten To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/181452: x11/xdialog: add radio knobs for GTK1/GTK2 (utf-8) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2013 11:40:00 -0000 >Number: 181452 >Category: ports >Synopsis: x11/xdialog: add radio knobs for GTK1/GTK2 (utf-8) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Aug 21 11:40:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Kalten >Release: 9.1-RELEASE-p* amd64 >Organization: >Environment: FreeBSD freeHugin.Walhalla.Leben 9.1-RELEASE-p5 FreeBSD 9.1-RELEASE-p5 #0: Sat Jul 27 01:14:23 UTC 2013 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 >Description: The program is capable of using GTK2 instead of GTK1. By this one can use UTF-8 encoding. (Some problems might occur---see note to v2.2.0 at http://xdialog.free.fr/doc/changelog.html). >How-To-Repeat: ``Xdialog --inputbox "Österreich" 0 0 "Iß was!"'' that were ``Österreich'' and ``Iß was!'' ;-) >Fix: Now there are radio knobs, defaulting to GTK1 (stable variant). (see attached patch file) Patch attached with submission follows: diff --git a/x11/xdialog/Makefile b/x11/xdialog/Makefile index e6e6333..e3b1b0b 100644 --- a/x11/xdialog/Makefile +++ b/x11/xdialog/Makefile @@ -1,9 +1,9 @@ # Created by: Ying-Chieh Liao -# $FreeBSD: x11/xdialog/Makefile 317383 2013-05-04 22:25:56Z bapt $ +# $FreeBSD$ PORTNAME= xdialog PORTVERSION= 2.3.1 -PORTREVISION= 5 +PORTREVISION= 6 CATEGORIES= x11 MASTER_SITES= http://xdialog.free.fr/ DISTNAME= ${PORTNAME:S/x/X/}-${PORTVERSION} @@ -12,7 +12,6 @@ MAINTAINER= sylvio@FreeBSD.org COMMENT= A drop in replacement for the "dialog" or "cdialog" programs USE_BZIP2= yes -USE_GNOME= gtk12 GNU_CONFIGURE= yes MAN1= Xdialog.1 @@ -24,8 +23,22 @@ LDFLAGS+= -L${LOCALBASE}/lib USE_GMAKE= yes .endif +OPTIONS_SINGLE= GTK_VERSION +OPTIONS_SINGLE_GTK_VERSION= GTK1 GTK2 +GTK1_DESC= GTK+ 1 GUI toolkit support (no UTF-8 support) +GTK2_DESC= GTK+ 2 GUI toolkit support (add UTF-8 support. Alpha!) + +OPTIONS_DEFAULT= GTK1 + .include +.if ${PORT_OPTIONS:MGTK2} +CONFIGURE_ARGS+= --with-gtk2 +USE_GNOME= gtk20 +.else +USE_GNOME= gtk12 +.endif + .if empty(PORT_OPTIONS:MNLS) CONFIGURE_ARGS+= --disable-nls PLIST_SUB+= NLS="@comment " diff --git a/x11/xdialog/pkg-descr b/x11/xdialog/pkg-descr index 0834d5a..363982c 100644 --- a/x11/xdialog/pkg-descr +++ b/x11/xdialog/pkg-descr @@ -3,5 +3,10 @@ Xdialog is designed to be a drop in replacement for the "dialog" or program with an X-windows interface. The dialogs are easier to see and use while adding even more functionalities. +Beware! If you select the GTK2 knob, you can use UTF-8 encoding for in- +and output, but output on non-UTF-8 systems leads to trouble. Further +not everything of the GTK1 version is implemented in the GTK2 version! +(see note to v2.2.0 at http://xdialog.free.fr/doc/changelog.html) + Author: Thierry Godefroy WWW: http://xdialog.free.fr/ >Release-Note: >Audit-Trail: >Unformatted: