Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Oct 2008 23:13:37 GMT
From:      Jeff Burchell <toxic@doobie.com>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/128106: Updated Port: news/nzbget  from 0.4.1 to 0.5.1
Message-ID:  <200810142313.m9ENDbPw073744@www.freebsd.org>
Resent-Message-ID: <200810142320.m9ENK1Rp069754@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         128106
>Category:       ports
>Synopsis:       Updated Port: news/nzbget  from 0.4.1 to 0.5.1
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 14 23:20:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Jeff Burchell
>Release:        7.0-RELEASE-p5
>Organization:
>Environment:
FreeBSD kvmfbsd.zyxyz.org 7.0-RELEASE-p5 FreeBSD 7.0-RELEASE-p5 #0: WedOct  1 07:51:58 UTC 2008     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
nzbget 0.5.1 was released as nzbget-stable on the 21st of September, 2008.  

For this port, the upstream source was modified to remove Linux-specific code that is used to produce core dump files (introduced in nzbget 0.5.0).  The DumpCore nzbget.conf option was removed, and the appropriate notes were made in the Changelog and example configuration files.
>How-To-Repeat:

>Fix:


Patch attached with submission follows:

Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/news/nzbget/Makefile,v
retrieving revision 1.11
diff -u -r1.11 Makefile
--- Makefile	4 Sep 2008 01:01:56 -0000	1.11
+++ Makefile	14 Oct 2008 22:00:22 -0000
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	nzbget
-PORTVERSION=	0.4.1
+PORTVERSION=	0.5.1
 CATEGORIES=	news
 MASTER_SITES=	SF
 
@@ -17,14 +17,14 @@
 		uu.3:${PORTSDIR}/converters/uulib
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include" \
+CONFIGURE_ENV=	CPPFLAGS="${CPPFLAGS} -I${LOCALBASE}/include -D__FREEBSD__" \
 		CFLAGS="${CFLAGS} ${PTHREAD_CFLAGS}" LDFLAGS="${PTHREAD_LIBS}" \
 		LOCALBASE="${LOCALBASE}"
 USE_GMAKE=	yes
 
 OPTIONS=	PARCHECK "Enable autopar/parcheck (Requires libpar2)" On
 
-PLIST_FILES=	bin/nzbget etc/nzbget.conf.example
+PLIST_FILES=	bin/nzbget
 PORTDOCS=	README
 PORTEXAMPLES=	nzbget.conf.example
 
@@ -38,8 +38,7 @@
 .endif
 
 do-install:
-	@${INSTALL_DATA} ${WRKSRC}/nzbget.conf.example ${PREFIX}/etc
-	@${INSTALL_DATA} ${WRKSRC}/nzbget ${PREFIX}/bin
+	@${INSTALL_PROGRAM} ${WRKSRC}/nzbget ${PREFIX}/bin
 .if !defined(NOPORTDOCS)
 	${MKDIR} ${DOCSDIR}
 	${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR}
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/news/nzbget/distinfo,v
retrieving revision 1.6
diff -u -r1.6 distinfo
--- distinfo	4 Sep 2008 01:01:56 -0000	1.6
+++ distinfo	14 Oct 2008 22:00:22 -0000
@@ -1,3 +1,3 @@
-MD5 (nzbget-0.4.1.tar.gz) = 08803146d2ffc4792cc0f12cdbf03da0
-SHA256 (nzbget-0.4.1.tar.gz) = aae9e1b9b0eb7f4f6418a1e0e516c583fab43d37e6ecc1ffc4f729bdd7e4c69e
-SIZE (nzbget-0.4.1.tar.gz) = 251338
+MD5 (nzbget-0.5.1.tar.gz) = 3ff7cb297bbe0fd3aa378343849d85f1
+SHA256 (nzbget-0.5.1.tar.gz) = 48af705afa1cb429562e1b9e27f854e60de62f3c4ef3775229051f82be9f57ff
+SIZE (nzbget-0.5.1.tar.gz) = 278007
Index: files/patch-ChangeLog
===================================================================
RCS file: files/patch-ChangeLog
diff -N files/patch-ChangeLog
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-ChangeLog	14 Oct 2008 22:00:22 -0000
@@ -0,0 +1,10 @@
+--- ChangeLog	2008-09-21 09:16:48.000000000 -0700
++++ ChangeLog	2008-10-02 16:59:34.000000000 -0700
+@@ -1,3 +1,7 @@
++nzbget-0.5.1 FreeBSD Port:
++  - Removed the <DumpCore> option, introduced in 0.5.0.  It uses 
++    Linux-specific code.
++
+ nzbget-0.5.1:
+   - improved the check of server responses to prevent unnecessary retrying
+     if the article does not exist on server;
Index: files/patch-configure
===================================================================
RCS file: /home/ncvs/ports/news/nzbget/files/patch-configure,v
retrieving revision 1.2
diff -u -r1.2 patch-configure
--- files/patch-configure	19 Mar 2008 12:38:00 -0000	1.2
+++ files/patch-configure	14 Oct 2008 22:00:22 -0000
@@ -1,14 +1,13 @@
---- configure.old	2008-02-29 12:18:26.000000000 -0300
-+++ configure	2008-02-29 12:20:35.000000000 -0300
-@@ -2362,7 +2362,10 @@
-     CPPFLAGS1="${CPPFLAGS} -D_GNU_SOURCE"
+--- configure	2008-09-21 09:18:06.000000000 -0700
++++ configure	2008-10-02 17:12:54.000000000 -0700
+@@ -2389,7 +2389,9 @@
+     LIBPREF1="/usr"
      ;;
    *-freebsd*)
 -    LIBPREF1="/usr/local"
 +    LIBPREF1="${LOCALBASE}"
 +    CFLAGS="${CFLAGS}"
 +    CPPFLAGS="${CPPFLAGS}"
-+    PLATFORM="FreeBSD"
      ;;
    *-solaris*)
      LIBPREF1="/usr"
Index: files/patch-nzbget.conf.example
===================================================================
RCS file: files/patch-nzbget.conf.example
diff -N files/patch-nzbget.conf.example
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-nzbget.conf.example	14 Oct 2008 22:00:22 -0000
@@ -0,0 +1,16 @@
+--- nzbget.conf.example	2008-08-22 07:50:40.000000000 -0700
++++ nzbget.conf.example	2008-10-02 17:00:00.000000000 -0700
+@@ -307,11 +307,11 @@
+ # the names of broken files
+ CreateBrokenLog=yes
+ 
+-# Create memory dump (core-file) on abnormal termination (POSIX only) (yes, no)
++# Create memory dump (core-file) on abnormal termination (Linux only) (yes, no)
+ # Core-files are very helpful for debugging.
+ # NOTE: core-files may contain sensible data, like your login/password to
+ # newsserver etc.
+-DumpCore=no
++# DumpCore=no
+ 
+ # See also option "logfile" in secion "PATHS"
+ 
Index: files/patch-nzbget.cpp
===================================================================
RCS file: files/patch-nzbget.cpp
diff -N files/patch-nzbget.cpp
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-nzbget.cpp	14 Oct 2008 22:00:22 -0000
@@ -0,0 +1,53 @@
+--- nzbget.cpp	2008-09-11 13:42:36.000000000 -0700
++++ nzbget.cpp	2008-10-02 16:57:26.000000000 -0700
+@@ -41,7 +41,9 @@
+ #include <pwd.h>
+ #include <grp.h>
+ #include <sys/resource.h>
++#ifndef __FREEBSD__
+ #include <sys/prctl.h>
++#endif
+ #include <signal.h>
+ #endif
+ #include <sys/types.h>
+@@ -82,7 +84,9 @@
+ void InstallSignalHandlers();
+ void Daemonize();
+ void PrintBacktrace();
++#ifndef __FREEBSD__
+ void EnableDumpCore();
++#endif
+ #ifdef DEBUG
+ void MakeSegFault();
+ #endif
+@@ -170,11 +174,13 @@
+ 	}
+ 
+ #ifndef WIN32
++#ifndef __FREEBSD__
+ 	if (g_pOptions->GetDumpCore())
+ 	{
+ 		EnableDumpCore();
+ 	}
+ #endif
++#endif
+ 
+ 	Run();
+ 
+@@ -518,6 +524,7 @@
+ }
+ #endif
+ 
++#ifndef __FREEBSD__
+ /**
+ * activates the creation of core-files
+ */
+@@ -530,6 +537,8 @@
+ 	prctl(PR_SET_DUMPABLE, 1);
+ }
+ #endif
++#endif
++
+ 
+ void Cleanup()
+ {


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810142313.m9ENDbPw073744>