From owner-cvs-src@FreeBSD.ORG Thu Aug 26 21:46:04 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B455716A4CE; Thu, 26 Aug 2004 21:46:04 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4E89E43D66; Thu, 26 Aug 2004 21:46:04 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7QLjiVk003174; Thu, 26 Aug 2004 15:45:44 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 26 Aug 2004 15:46:11 -0600 (MDT) Message-Id: <20040826.154611.56055412.imp@bsdimp.com> To: green@freebsd.org From: "M. Warner Losh" In-Reply-To: <20040826201531.GQ77326@green.homeunix.org> References: <20040826200728.GP77326@green.homeunix.org> <66211.1093550956@critter.freebsd.dk> <20040826201531.GQ77326@green.homeunix.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: src-committers@freebsd.org cc: pjd@freebsd.org cc: cvs-src@freebsd.org cc: cvs-all@freebsd.org cc: rik@cronyx.ru cc: phk@phk.freebsd.dk Subject: Re: cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 21:46:04 -0000 In message: <20040826201531.GQ77326@green.homeunix.org> Brian Fundakowski Feldman writes: : On Thu, Aug 26, 2004 at 10:09:16PM +0200, Poul-Henning Kamp wrote: : > In message <20040826200728.GP77326@green.homeunix.org>, Brian Fundakowski Feldm : > an writes: : > : > >> They have been very successful in this respect, and more will be : > >> added as I think them up. : > > : > >Why in the world would you crash the machine when you don't have to? : > : > To prevent bogus code from being committed in the first place. : > : > Presumably if people can not make their code work because it panics : > they will not commit it. : : You cannot presume testing will expose every possible state/condition. : It hasn't in FreeBSD's past, but maybe you can start a revolution that : makes it simple to create very complete test suites and put them into : the tree along with the code being tested. I beg to differ. newbus has lots of asserts in it that could be recovered from, but instead are panics. These panics have been very helpful in shaking out bugs (much to the annoyance of the person doing the work until the bugs were figured out). Warner