Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 May 2025 09:14:08 GMT
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 97c799661a76 - main - dwc_otg_fdt: do not create and leak extra usbus child
Message-ID:  <202505190914.54J9E8DN093112@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by avg:

URL: https://cgit.FreeBSD.org/src/commit/?id=97c799661a76b78963fd9f92a7e6bb452ebba999

commit 97c799661a76b78963fd9f92a7e6bb452ebba999
Author:     Andriy Gapon <avg@FreeBSD.org>
AuthorDate: 2025-05-19 09:06:55 +0000
Commit:     Andriy Gapon <avg@FreeBSD.org>
CommitDate: 2025-05-19 09:08:43 +0000

    dwc_otg_fdt: do not create and leak extra usbus child
    
    dwc_otg_init() already takes care of creating the bus and setting up sc
    to point to it.
    
    Fixes:          518da7ace813e
    MFC after:      1 week
---
 sys/dev/usb/controller/dwc_otg_fdt.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sys/dev/usb/controller/dwc_otg_fdt.c b/sys/dev/usb/controller/dwc_otg_fdt.c
index 3d5dcb9e9a7b..2ed94b23212c 100644
--- a/sys/dev/usb/controller/dwc_otg_fdt.c
+++ b/sys/dev/usb/controller/dwc_otg_fdt.c
@@ -140,10 +140,6 @@ dwc_otg_attach(device_t dev)
 	if (sc->sc_otg.sc_irq_res == NULL)
 		goto error;
 
-	sc->sc_otg.sc_bus.bdev = device_add_child(dev, "usbus", DEVICE_UNIT_ANY);
-	if (sc->sc_otg.sc_bus.bdev == NULL)
-		goto error;
-
 	err = dwc_otg_init(&sc->sc_otg);
 	if (err == 0) {
 		err = device_probe_and_attach(sc->sc_otg.sc_bus.bdev);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202505190914.54J9E8DN093112>