From owner-cvs-src@FreeBSD.ORG Sat Apr 1 16:20:55 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 174BC16A422; Sat, 1 Apr 2006 16:20:55 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D82F943D46; Sat, 1 Apr 2006 16:20:54 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k31GKsCd028620; Sat, 1 Apr 2006 16:20:54 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k31GKsGQ028619; Sat, 1 Apr 2006 16:20:54 GMT (envelope-from rwatson) Message-Id: <200604011620.k31GKsGQ028619@repoman.freebsd.org> From: Robert Watson Date: Sat, 1 Apr 2006 16:20:54 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netinet ip_divert.c raw_ip.c udp_usrreq.c src/sys/netinet6 raw_ip6.c udp6_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2006 16:20:55 -0000 rwatson 2006-04-01 16:20:54 UTC FreeBSD src repository Modified files: sys/netinet ip_divert.c raw_ip.c udp_usrreq.c sys/netinet6 raw_ip6.c udp6_usrreq.c Log: Update in_pcb-derived basic socket types following changes to pru_abort(), pru_detach(), and in_pcbdetach(): - Universally support and enforce the invariant that so_pcb is never NULL, converting dozens of unnecessary NULL checks into assertions, and eliminating dozens of unnecessary error handling cases in protocol code. - In some cases, eliminate unnecessary pcbinfo locking, as it is no longer required to ensure so_pcb != NULL. For example, in protocol shutdown methods, and in raw IP send. - Abort and detach protocol switch methods no longer return failures, nor attempt to free sockets, as the socket layer does this. - Invoke in_pcbfree() after in_pcbdetach() in order to free the detached in_pcb structure for a socket. MFC after: 3 months Revision Changes Path 1.116 +15 -34 src/sys/netinet/ip_divert.c 1.159 +24 -60 src/sys/netinet/raw_ip.c 1.185 +16 -35 src/sys/netinet/udp_usrreq.c 1.60 +13 -22 src/sys/netinet6/raw_ip6.c 1.59 +18 -48 src/sys/netinet6/udp6_usrreq.c