From owner-freebsd-arch@FreeBSD.ORG Wed Feb 24 15:18:42 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 819D91065670 for ; Wed, 24 Feb 2010 15:18:42 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-iw0-f185.google.com (mail-iw0-f185.google.com [209.85.223.185]) by mx1.freebsd.org (Postfix) with ESMTP id 475F78FC08 for ; Wed, 24 Feb 2010 15:18:41 +0000 (UTC) Received: by iwn15 with SMTP id 15so4192988iwn.7 for ; Wed, 24 Feb 2010 07:18:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=dOTXLnKbAwETmr8S4fuM0LcHYsspskfRjiNroOgn/PQ=; b=aRNJW3uz2V/4JRs2yyCDw+9ShIQh5n7jRtuuQCYWA1S8B/wgq7jjd15TFUqMnAMUUu HaARNA40DfwNDD0GOx64hQBjlexiOg6QLMoipNS2gem0AHhLDyKsRLEHkMx6GcSUjkZU KBsw4tFIgCZ9oCKmkmm+hv8qMhQC6D8GbFH8s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=HSv//TUkBKX7JE7dMTvCiaGzV1XqDQ9QrhYHQvmgN+Fg+VoBAf/hQvLlGqJq2G8m8N M94da4xnoxHwp6B4AtNE1ji1/kZAFLiDjxnzH2R6I7NY3XrG4cxSlP7DRrgcmZqlzzrC yzjleg56lzn6Z5DxpkgJCyVMVB+vRY0HFQc/c= MIME-Version: 1.0 Sender: asmrookie@gmail.com Received: by 10.231.156.205 with SMTP id y13mr844681ibw.27.1267024714664; Wed, 24 Feb 2010 07:18:34 -0800 (PST) In-Reply-To: <20100216195440.GF50403@deviant.kiev.zoral.com.ua> References: <3bbf2fe11002151610l41526f55r5e60b5e46ce42b64@mail.gmail.com> <20100216195440.GF50403@deviant.kiev.zoral.com.ua> Date: Wed, 24 Feb 2010 16:18:34 +0100 X-Google-Sender-Auth: d8d4c1f5795fcb17 Message-ID: <3bbf2fe11002240718x5182aa93w5a00c657a0fba5f6@mail.gmail.com> From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Arch , Ed Maste Subject: Re: [PATCH] Adding shared code support for ia32 and amd64 -- x86 sub-branch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2010 15:18:42 -0000 2010/2/16 Kostik Belousov : > On Tue, Feb 16, 2010 at 01:10:37AM +0100, Attilio Rao wrote: >> The following patch: >> http://www.freebsd.org/~attilio/x86.diff >> >> starts the effort for having a shared sub-tree between amd64 and ia32. >> In this initial pass I putted the low-hanging fruits (bios/cpufreq) >> and what my customer was more interested in (isa/*) in order to >> kick-off the effort and, in the future, move gradually the code there. >> With the machine/isa/* cleanup about 10 files are trimmed and I'm sure >> more can be achieved easilly. >> There are few things to discuss. One, that I had not necessity to dig >> about still, is about how to organize headers (include/). Maybe some >> replication ala pc98 may be good. >> >> The patch is big but it is mostly added and removed files (look at the >> files.X in order to understand better how files movements happened). >> >> Hope to see comments and reviews. > > IMO the diff is unreadable. I suggest to do actual svn cp (not svn mv) > operation now, without a review, and post a diff that should be applied > to x86/ directory, as well as to build glue. I think that this patch juices out all the relevant part without noise: http://www.freebsd.org/~attilio/x86-2.diff Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein