From owner-freebsd-current@FreeBSD.ORG  Tue Dec 20 21:49:07 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E8CE91065672;
	Tue, 20 Dec 2011 21:49:07 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id BECCB8FC08;
	Tue, 20 Dec 2011 21:49:07 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
	by cyrus.watson.org (Postfix) with ESMTPSA id 7516E46B2A;
	Tue, 20 Dec 2011 16:49:07 -0500 (EST)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 0AEB3B93A;
	Tue, 20 Dec 2011 16:49:07 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Robert Watson <rwatson@freebsd.org>
Date: Tue, 20 Dec 2011 16:49:06 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; )
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201112201649.06265.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 20 Dec 2011 16:49:07 -0500 (EST)
Cc: current@freebsd.org
Subject: extattr_set_*() return type
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2011 21:49:08 -0000

Hmm, if these functions are expected to operate like 'write(2)' and are 
supposed to return the number of bytes written, shouldn't their return value 
be 'ssize_t' instead of 'int'?  It looks like the system calls themselves 
already do the right thing in setting td_retval[] (they assign a ssize_t to it 
and td_retval[0] can hold a ssize_t on all of our current platforms).  It 
would seem that the only change would be to the header and probably 
syscalls.master.  I guess this would require a symver bump to fix though.

-- 
John Baldwin