From owner-freebsd-bugs@FreeBSD.ORG Tue Mar 28 13:50:13 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BEBD16A425 for ; Tue, 28 Mar 2006 13:50:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 69F5E43D58 for ; Tue, 28 Mar 2006 13:50:12 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k2SDoCch091054 for ; Tue, 28 Mar 2006 13:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k2SDoCgM091053; Tue, 28 Mar 2006 13:50:12 GMT (envelope-from gnats) Resent-Date: Tue, 28 Mar 2006 13:50:12 GMT Resent-Message-Id: <200603281350.k2SDoCgM091053@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Hans Lambermont Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6A2FB16A400 for ; Tue, 28 Mar 2006 13:44:42 +0000 (UTC) (envelope-from hans@lambermont.dyndns.org) Received: from lambermont.dyndns.org (lambermont.dyndns.org [82.93.47.245]) by mx1.FreeBSD.org (Postfix) with ESMTP id B27AD43D4C for ; Tue, 28 Mar 2006 13:44:41 +0000 (GMT) (envelope-from hans@lambermont.dyndns.org) Received: by lambermont.dyndns.org (Postfix, from userid 1001) id C315814DA01; Tue, 28 Mar 2006 15:44:40 +0200 (CEST) Received: from gagh.intra.aramiska.net (norsk [81.246.41.162]) by lambermont.dyndns.org (Postfix) with ESMTP id 8E4D614DA01 for ; Tue, 28 Mar 2006 15:35:20 +0200 (CEST) Received: by gagh.intra.aramiska.net (Postfix, from userid 1001) id 094F4EBCC4; Tue, 28 Mar 2006 14:31:50 +0200 (CEST) Message-Id: <20060328123150.094F4EBCC4@gagh.intra.aramiska.net> Date: Tue, 28 Mar 2006 14:31:50 +0200 (CEST) From: Hans Lambermont To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Hans Lambermont Subject: bin/95041: patch for mrouted subnet mask checking on interface aliases X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Hans Lambermont List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2006 13:50:13 -0000 >Number: 95041 >Category: bin >Synopsis: patch for mrouted subnet mask checking on interface aliases >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 28 13:50:11 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Hans Lambermont >Release: FreeBSD 6.0-BETA2 i386 >Organization: Sangine >Environment: System: FreeBSD gagh.intra.aramiska.net 6.0-BETA2 FreeBSD 6.0-BETA2 #5: Thu Nov 3 14:05:37 CET 2005 hans@gagh.intra.aramiska.net:/usr/obj/new/usr/src/sys/GAGH i386 >Description: mrouted calls the inet_valid_subnet function with wrong subnet mask for interface aliases. >How-To-Repeat: fxp1: flags=8b43 mtu 1500 options=b inet 172.31.254.253 netmask 0xfffffffc broadcast 172.31.254.255 inet 10.0.0.3 netmask 0xfffffff8 broadcast 10.0.0.7 generates : mrouted[904]: warning - test fxp1, addr(172.31.254.253) mask(255.255.255.252) subnet(172.31.254.252) mrouted[904]: warning - test fxp1, addr(10.0.0.3) mask(255.255.255.252) subnet(10.0.0.0) mrouted[904]: warning - ignoring fxp1, has invalid address (10.0.0.3) and/or mask (255.255.255.252) the 10.0.0.3 entries' mask is checked against the 172.31.254.253' mask. >Fix: --- config.c.org Tue Mar 28 14:15:34 2006 +++ config.c Tue Mar 28 14:17:37 2006 @@ -105,16 +105,16 @@ * valid subnet number, or whose address is of the form {subnet,0} * or {subnet,-1}. */ - if (ioctl(udp_socket, SIOCGIFNETMASK, (char *)&ifr) < 0) - log(LOG_ERR, errno, "ioctl SIOCGIFNETMASK for %s", ifr.ifr_name); - mask = ((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr.s_addr; + if (ioctl(udp_socket, SIOCGIFNETMASK, (char *)ifrp) < 0) + log(LOG_ERR, errno, "ioctl SIOCGIFNETMASK for %s", ifrp->ifr_name); + mask = ((struct sockaddr_in *)&ifrp->ifr_addr)->sin_addr.s_addr; subnet = addr & mask; if (!inet_valid_subnet(subnet, mask) || addr == subnet || addr == (subnet | ~mask)) { log(LOG_WARNING, 0, "ignoring %s, has invalid address (%s) and/or mask (%s)", - ifr.ifr_name, inet_fmt(addr, s1), inet_fmt(mask, s2)); + ifrp->ifr_name, inet_fmt(addr, s1), inet_fmt(mask, s2)); continue; } >Release-Note: >Audit-Trail: >Unformatted: