Date: Tue, 28 Mar 2006 14:31:50 +0200 (CEST) From: Hans Lambermont <hans@lambermont.dyndns.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: Hans Lambermont <hans@lambermont.dyndns.org> Subject: bin/95041: patch for mrouted subnet mask checking on interface aliases Message-ID: <20060328123150.094F4EBCC4@gagh.intra.aramiska.net> Resent-Message-ID: <200603281350.k2SDoCgM091053@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 95041 >Category: bin >Synopsis: patch for mrouted subnet mask checking on interface aliases >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 28 13:50:11 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Hans Lambermont >Release: FreeBSD 6.0-BETA2 i386 >Organization: Sangine >Environment: System: FreeBSD gagh.intra.aramiska.net 6.0-BETA2 FreeBSD 6.0-BETA2 #5: Thu Nov 3 14:05:37 CET 2005 hans@gagh.intra.aramiska.net:/usr/obj/new/usr/src/sys/GAGH i386 >Description: mrouted calls the inet_valid_subnet function with wrong subnet mask for interface aliases. >How-To-Repeat: fxp1: flags=8b43<UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST> mtu 1500 options=b<RXCSUM,TXCSUM,VLAN_MTU> inet 172.31.254.253 netmask 0xfffffffc broadcast 172.31.254.255 inet 10.0.0.3 netmask 0xfffffff8 broadcast 10.0.0.7 generates : mrouted[904]: warning - test fxp1, addr(172.31.254.253) mask(255.255.255.252) subnet(172.31.254.252) mrouted[904]: warning - test fxp1, addr(10.0.0.3) mask(255.255.255.252) subnet(10.0.0.0) mrouted[904]: warning - ignoring fxp1, has invalid address (10.0.0.3) and/or mask (255.255.255.252) the 10.0.0.3 entries' mask is checked against the 172.31.254.253' mask. >Fix: --- config.c.org Tue Mar 28 14:15:34 2006 +++ config.c Tue Mar 28 14:17:37 2006 @@ -105,16 +105,16 @@ * valid subnet number, or whose address is of the form {subnet,0} * or {subnet,-1}. */ - if (ioctl(udp_socket, SIOCGIFNETMASK, (char *)&ifr) < 0) - log(LOG_ERR, errno, "ioctl SIOCGIFNETMASK for %s", ifr.ifr_name); - mask = ((struct sockaddr_in *)&ifr.ifr_addr)->sin_addr.s_addr; + if (ioctl(udp_socket, SIOCGIFNETMASK, (char *)ifrp) < 0) + log(LOG_ERR, errno, "ioctl SIOCGIFNETMASK for %s", ifrp->ifr_name); + mask = ((struct sockaddr_in *)&ifrp->ifr_addr)->sin_addr.s_addr; subnet = addr & mask; if (!inet_valid_subnet(subnet, mask) || addr == subnet || addr == (subnet | ~mask)) { log(LOG_WARNING, 0, "ignoring %s, has invalid address (%s) and/or mask (%s)", - ifr.ifr_name, inet_fmt(addr, s1), inet_fmt(mask, s2)); + ifrp->ifr_name, inet_fmt(addr, s1), inet_fmt(mask, s2)); continue; } >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060328123150.094F4EBCC4>