Date: Mon, 30 Mar 2015 16:19:41 -0600 From: Randall Stewart <rrs@netflix.com> To: Davide Italiano <davide@FreeBSD.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys Message-ID: <10B55CA1-47E5-43FE-9DC1-AEE4A964A65C@netflix.com> In-Reply-To: <CACYV=-G28b6RpMq62zCykVtPJeJ17TTHqN3pj7rsM9Q-=nMHyg@mail.gmail.com> References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <CACYV=-FBYMN6HoRqtycXMx_CuwDWcLaB_gstK=_P0SkDTFXn_A@mail.gmail.com> <4E7E0A0A-5125-4F3A-AC0C-D428A972C954@netflix.com> <CACYV=-G28b6RpMq62zCykVtPJeJ17TTHqN3pj7rsM9Q-=nMHyg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Davide: I have had a long chat this weekend with imp, and both he and I feel the = right fix is to *not* bump the version, but instead change the two fields to = shorts. That way the length will still say the same so we can MFC this. I will be committing that shortly, I have it testing inside right now=85 = :-) R On Mar 28, 2015, at 2:48 PM, Davide Italiano <davide@FreeBSD.org> wrote: > On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart <rrs@netflix.com> = wrote: >> Hmm does the KPI include the size of the callout structure (which is >> private)? >>=20 >=20 > It's KBI, not KPI. >=20 >> If so I suppose we could change the c_flags/c_iflags to >> ushort =85 >>=20 >=20 > I'm not familiar with your changes enough to suggest/propose a fix. > As I previously mentioned, this looks suspicious KBI-wise to me, and I > reported to you. >=20 > --=20 > Davide >=20 > "There are no solved problems; there are only problems that are more > or less solved" -- Henri Poincare -------- Randall Stewart rrs@netflix.com 803-317-4952
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?10B55CA1-47E5-43FE-9DC1-AEE4A964A65C>