From owner-svn-ports-all@FreeBSD.ORG Mon Dec 2 11:57:23 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5A5F3F60; Mon, 2 Dec 2013 11:57:23 +0000 (UTC) Received: from mail-ea0-x22f.google.com (mail-ea0-x22f.google.com [IPv6:2a00:1450:4013:c01::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 485A51D81; Mon, 2 Dec 2013 11:57:22 +0000 (UTC) Received: by mail-ea0-f175.google.com with SMTP id z10so8846110ead.20 for ; Mon, 02 Dec 2013 03:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=fC0beQl9cqSrBo4B4IdA8v3hPLJuSzxsVilMnA3kZkk=; b=qY+DGkgA8TSOe3kKb0C05fr14khiRiWEtEeT5H4jMqzgHHexjp/YiqFCwylP1Szj41 3HL8rKYGbvIx7kuM62G7FzjqL0cmxONPI2IlmX6z2u94UGN+oACAFJsisPPNSzY6HcM7 buPMQYNjcV/d/TEbiZm24XnGWPopoTXpxN3o8lwo5uCZHyXGN8JQ2c1nnwI8tyKqdNif ydhDmsr4+CayRvru/xpa3QN2Uok/Z8nsN7wgnkx7maUuXtfV+OjqB83S+jUbdRyLRv/V F8SHsX1jKUUzJfyVSpw7lPBB2BU8+DNv1o4X/0m2IOGjmM9e1Ww24RuZX82820sGWVV/ BaDg== X-Received: by 10.14.216.200 with SMTP id g48mr155023eep.129.1385985440708; Mon, 02 Dec 2013 03:57:20 -0800 (PST) Received: from [192.168.77.101] (mail1.amcu.gov.ua. [213.160.139.2]) by mx.google.com with ESMTPSA id j46sm70155149eew.18.2013.12.02.03.57.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Dec 2013 03:57:19 -0800 (PST) Message-ID: <529C7599.1050509@gmail.com> Date: Mon, 02 Dec 2013 13:57:13 +0200 From: Kozlov Sergey User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: Mathieu Arnold , Gerald Pfeifer , Greg Larkin Subject: Re: svn commit: r335189 - in head/print/pdftk: . files References: <201311291548.rATFm8g7098382@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 11:57:23 -0000 On 02.12.2013 12:08, Mathieu Arnold wrote: > +--On 1 décembre 2013 23:21:51 +0100 Gerald Pfeifer > wrote: > | On Fri, 29 Nov 2013, Mathieu Arnold wrote: > |> Log: > |> Updated port to pdftk-2.02 > | : > |> - Added LIB_DEPENDS. Libraries provided by gcc required to run the > |> binary, but gcc is registered only as build dependency. Removing the > |> gcc after installation of pdftk is permitted but breaks pdftk > | > | This looks quite dubious since USE_GCC already takes care of > | registering this run-time dependency. > | > | USE_GCC also takes care of the BUILD_DEPENDency, so the pre-existing > | entry there also is unnecessary. > > Hum, does GCC always come with gcj ? I thought it did not, that's why there > was an explicit dependency on it. 1. GCC does not always come with gcj, user can compile the port without it. So pdftk needs both gcc and gcj to build, and they are added explicitly as build dependencies. 2. USE_GCC register GCC (and not gcj) only as build dependency, so additional lib-dependencies are required. > |> maintainer timeout. > | > | This reminds me, I had submitted another patch in August 2012 (per > | mail, not PR). The -Wl,-path magic is not necessary and manually > | constructing the path to the GCC run-time libraries is A Bad Idea[TM]. > | This is what ${LDFLAGS} is there for, and what the second, and more > | important hunk, in my patch below does. > | > | Can you guys please give the patch below a spin and review? > > The patch looks ok to me, but I don't know a lot about how all that dark > magic works :-p > 3. Just as mat, I don't know a lot about all the dark magic, so while preparing the patch I just left these parts be, and tested the build and resulting binary. Thanks, Kozlov Sergey.